All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/4] meter: add meter configuration profile api
Date: Thu, 12 Oct 2017 22:51:05 +0200	[thread overview]
Message-ID: <2009950.PBKcGuERrl@xps> (raw)
In-Reply-To: <1503488186-90047-1-git-send-email-cristian.dumitrescu@intel.com>

> Cristian Dumitrescu (4):
>   meter: add meter configuration profile
>   test: meter autotest update
>   qos_meter: accommodate meter api changes
>   deprecation: removed the librte_meter notice
> 
>  doc/guides/rel_notes/deprecation.rst   |   3 -
>  examples/qos_meter/main.c              |  36 ++++---
>  examples/qos_meter/main.h              |  32 ++++---
>  lib/librte_meter/rte_meter.c           |  88 ++++++++++-------
>  lib/librte_meter/rte_meter.h           | 170 ++++++++++++++++++++++-----------
>  lib/librte_meter/rte_meter_version.map |   8 ++
>  test/test/test_meter.c                 | 138 ++++++++++++++++----------
>  7 files changed, 306 insertions(+), 169 deletions(-)

There are too many checkpatches warnings.

And there is at least one compilation error with the first patch:

test/test/test_meter.c:93:34: fatal error: incompatible pointer types
	passing 'struct rte_meter_srtcm_params *' to parameter of type
	'struct rte_meter_srtcm_profile *' [-Wincompatible-pointer-types]

Please try to improve for RC2.

      parent reply	other threads:[~2017-10-12 20:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 11:36 [PATCH 0/4] meter: add meter configuration profile api Cristian Dumitrescu
2017-08-23 11:36 ` [PATCH 1/4] meter: add meter configuration profile Cristian Dumitrescu
2017-12-12  9:53   ` [PATCH v2 0/4] meter: add meter configuration profile api Jasvinder Singh
2017-12-12  9:53     ` [PATCH v2 1/4] lib/librte_meter: add meter configuration profile Jasvinder Singh
2018-01-08 10:00       ` [PATCH v3] meter: add meter configuration profile api Jasvinder Singh
2018-01-08 10:00         ` [PATCH v3] lib/librte_meter: add meter configuration profile Jasvinder Singh
2018-01-08 15:43           ` [PATCH v4] " Jasvinder Singh
2018-01-11 13:54             ` Dumitrescu, Cristian
2018-02-19 21:12             ` Thomas Monjalon
2018-04-05 10:12               ` Thomas Monjalon
2018-04-05 11:00                 ` Dumitrescu, Cristian
2017-12-12  9:53     ` [PATCH v2 2/4] test/test_meter: update meter test Jasvinder Singh
2017-12-12  9:53     ` [PATCH v2 3/4] examples/qos_meter: accommodate meter api changes Jasvinder Singh
2017-12-12  9:53     ` [PATCH v2 4/4] examples/ip_pipeline: update flow action pipeline Jasvinder Singh
2017-08-23 11:36 ` [PATCH 2/4] test: meter autotest update Cristian Dumitrescu
2017-08-23 11:36 ` [PATCH 3/4] qos_meter: accommodate meter api changes Cristian Dumitrescu
2017-08-23 11:36 ` [PATCH 4/4] deprecation: removed the librte_meter notice Cristian Dumitrescu
2017-10-12 20:51 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2009950.PBKcGuERrl@xps \
    --to=thomas@monjalon.net \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.