All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Prokop <mika@grml.org>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, nico-linuxsetlocalversion@schottelius.org
Subject: Re: scripts/setlocalversion: information retrieval about git repository state
Date: Fri, 3 Sep 2010 13:58:54 +0200	[thread overview]
Message-ID: <2010-09-03T13-54-06@devnull.michael-prokop.at> (raw)
In-Reply-To: <4C77CB27.1070700@suse.cz>

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

* Michal Marek [Fri Aug 27, 2010 at 04:26:47PM +0200]:
> On 25.8.2010 01:03, Michael Prokop wrote:
> > Huh? Ok, scripts/setlocalversion uses 'git describe --exact-match':

> >   % git describe --exact-match
> >   fatal: no tag exactly matches 'd1b113bb028999e82a8528e1484be8c23fb5a7d9'
> >   % git branch --contains d1b113bb028999e82a8528e1484be8c23fb5a7d9
> >   * master

> Git describe only looks at annotated or signed tags (git tag -a/-s) by
> default.

Thanks for the pointer.

My issue is still valid though: scripts/setlocalversion of recent
kernel versions should be adjusted -> either check for the untagged
state or clarify/improve the comment about it. :)

I'd provide a patch for that if you let me know what's the way to
go.

regards,
-mika-

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2010-09-03 11:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-24 23:03 scripts/setlocalversion: information retrieval about git repository state Michael Prokop
2010-08-27 14:26 ` Michal Marek
2010-09-03 11:58   ` Michael Prokop [this message]
2010-09-03 12:10     ` Michal Marek
2010-09-06  9:57       ` [PATCH] scripts/setlocalversion: update comment regarding " Michael Prokop
2010-09-06 11:27         ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2010-09-03T13-54-06@devnull.michael-prokop.at \
    --to=mika@grml.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=nico-linuxsetlocalversion@schottelius.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.