From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NQg37-0001tv-Ig for mharc-grub-devel@gnu.org; Fri, 01 Jan 2010 06:52:09 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQg35-0001tg-W5 for grub-devel@gnu.org; Fri, 01 Jan 2010 06:52:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQg30-0001ru-Jq for grub-devel@gnu.org; Fri, 01 Jan 2010 06:52:06 -0500 Received: from [199.232.76.173] (port=40945 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQg2z-0001rr-PA for grub-devel@gnu.org; Fri, 01 Jan 2010 06:52:01 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:37976 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NQg2z-0005d7-AQ for grub-devel@gnu.org; Fri, 01 Jan 2010 06:52:01 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NQg2x-0005ui-8K for grub-devel@gnu.org; Fri, 01 Jan 2010 12:51:59 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NQg2w-00019j-Ge for grub-devel@gnu.org; Fri, 01 Jan 2010 12:51:58 +0100 Date: Fri, 1 Jan 2010 12:51:58 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20100101115158.GF3692@thorin> References: <4B39CC24.9060607@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4B39CC24.9060607@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] switch from sprintf to asprintf and snprintf X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2010 11:52:08 -0000 On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > sprintf is potentially dangerous especially with gettext, when messages > may be larger than coder would expect. I attach the patch to fix it Could you split the patches into one for asprintf and one for *nprintf? The asprintf one is something I'd really like to see in trunk. For the rest I'm not so sure. -- Robert Millan "Be the change you want to see in the world" -- Gandhi