From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NQgB4-0004mh-Ug for mharc-grub-devel@gnu.org; Fri, 01 Jan 2010 07:00:23 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQgB3-0004mb-20 for grub-devel@gnu.org; Fri, 01 Jan 2010 07:00:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQgAz-0004m5-22 for grub-devel@gnu.org; Fri, 01 Jan 2010 07:00:20 -0500 Received: from [199.232.76.173] (port=43813 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQgAy-0004m2-QR for grub-devel@gnu.org; Fri, 01 Jan 2010 07:00:16 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:40295 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NQgAy-000658-91 for grub-devel@gnu.org; Fri, 01 Jan 2010 07:00:16 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NQgAv-0005vA-FW for grub-devel@gnu.org; Fri, 01 Jan 2010 13:00:13 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NQgAs-0001EF-A0 for grub-devel@gnu.org; Fri, 01 Jan 2010 13:00:10 +0100 Date: Fri, 1 Jan 2010 13:00:10 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20100101120010.GH3692@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] compilation with external intl library X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2010 12:00:21 -0000 On Wed, Dec 30, 2009 at 11:23:38AM +0100, Yves Blusseau wrote: > Hi, > > this is the patch to "fix" compilation with external intl library. It fix the #28356 bug (http://savannah.gnu.org/bugs/?28356). > > I follow strictly the guideline of gettext, and now we can compile grub with external intl library. > > Some enhancements; > - We can disable NLS (Native Language Support) with the --disable-nls configure flag. > - We can choose where the external intl library is with the --with-libintl-prefix configure flag. > > Under linux the gettext macro detect that the gettext function is in libc and so don't add any flags (like before). > On other platform like Mac OSX, the macro add the proper compile and link flags (ex: -lintl -liconv -lc -Wl,-framework -Wl,CoreFoundation in OSX) > > Best Regards, > Yves Blusseau > > PS: if it ok i'll commit this patch and will add another one to make on error if the intl library can't be use and show alternative to compile grub. Hi Yves, Please can you adjust your mailer so that it marks text attachments as text/plain? It currently sets Content-Type: application/octet-stream which makes it hard to send a context-reply with my mailer. I had other comments, but in particular, config.rpath shouldn't be imported statically. Thanks! -- Robert Millan "Be the change you want to see in the world" -- Gandhi