All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH 3/3] Compilation with external intl library
Date: Fri, 1 Jan 2010 13:09:59 +0100	[thread overview]
Message-ID: <20100101120959.GK3692@thorin> (raw)
In-Reply-To: <20091231165509.28764.95501.stgit@yves.private.network>

On Thu, Dec 31, 2009 at 05:55:09PM +0100, Yves Blusseau wrote:
> 2009-12-31  Yves Blusseau  <blusseau@zetam.org>
> 
> 	* util/mkisofs/mkisofs.c: fix a warning about a bad cast when NLS
> 	is disabled
> ---
>  ChangeLog.bad-cast     |    6 ++++++
>  util/mkisofs/mkisofs.c |    2 +-
>  2 files changed, 7 insertions(+), 1 deletions(-)
>  create mode 100644 ChangeLog.bad-cast

> diff --git a/ChangeLog.bad-cast b/ChangeLog.bad-cast
> new file mode 100644
> index 0000000..97ee16b
> --- /dev/null
> +++ b/ChangeLog.bad-cast
> @@ -0,0 +1,6 @@
> +Compilation with external intl library
> +
> +2009-12-31  Yves Blusseau  <blusseau@zetam.org>
> +
> +	* util/mkisofs/mkisofs.c: fix a warning about a bad cast when NLS
> +	is disabled
> diff --git a/util/mkisofs/mkisofs.c b/util/mkisofs/mkisofs.c
> index 4ed091b..57e77dd 100644
> --- a/util/mkisofs/mkisofs.c
> +++ b/util/mkisofs/mkisofs.c
> @@ -490,7 +490,7 @@ void usage(){
>  	  int comma;
>  	  int len;
>  	  unsigned int j;
> -	  char *arg;
> +	  const char *arg;
>  
>  	  printf ("  ");

This is fine.  In the future, feel free to commit this kind of obvious
cleanup directly.

Thanks!

-- 
Robert Millan

  "Be the change you want to see in the world" -- Gandhi



      reply	other threads:[~2010-01-01 12:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-31 16:54 [PATCH] Compilation with external intl library Yves Blusseau
2009-12-31 16:54 ` [PATCH 1/3] " Yves Blusseau
2009-12-31 16:55 ` [PATCH 2/3] " Yves Blusseau
2010-01-01 12:08   ` Robert Millan
2009-12-31 16:55 ` [PATCH 3/3] " Yves Blusseau
2010-01-01 12:09   ` Robert Millan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100101120959.GK3692@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.