From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NQgLp-0000bS-AT for mharc-grub-devel@gnu.org; Fri, 01 Jan 2010 07:11:29 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQgLo-0000bF-0r for grub-devel@gnu.org; Fri, 01 Jan 2010 07:11:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQgLj-0000al-Kf for grub-devel@gnu.org; Fri, 01 Jan 2010 07:11:27 -0500 Received: from [199.232.76.173] (port=48673 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQgLj-0000ai-Dk for grub-devel@gnu.org; Fri, 01 Jan 2010 07:11:23 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:53032 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NQgLj-0006m3-0u for grub-devel@gnu.org; Fri, 01 Jan 2010 07:11:23 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NQgLh-0005wC-MR for grub-devel@gnu.org; Fri, 01 Jan 2010 13:11:21 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NQgLh-0002Ex-5k for grub-devel@gnu.org; Fri, 01 Jan 2010 13:11:21 +0100 Date: Fri, 1 Jan 2010 13:11:21 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20100101121121.GL3692@thorin> References: <20091231183156.GA25874@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091231183156.GA25874@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] macrofy (multiterm branch) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2010 12:11:28 -0000 On Thu, Dec 31, 2009 at 07:31:56PM +0100, Carles Pina i Estany wrote: > > Hi, > > Find an attached patch to macrofy pos >> 8 and pos & 0xff in multiter. > In my opinion should be macrofied, it's more clear. Agreed. > === modified file 'include/grub/term.h' > --- include/grub/term.h 2009-12-25 02:37:20 +0000 > +++ include/grub/term.h 2009-12-30 18:17:55 +0000 > @@ -32,6 +32,8 @@ > #define GRUB_TERM_ESC '\e' > #define GRUB_TERM_TAB '\t' > #define GRUB_TERM_BACKSPACE 8 > +#define GETX(XY) (XY >> 8) > +#define GETY(XY) (XY & 0xff) It should have GRUB_ prefix. Otherwise it can go in. -- Robert Millan "Be the change you want to see in the world" -- Gandhi