From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NQgWh-0005NZ-54 for mharc-grub-devel@gnu.org; Fri, 01 Jan 2010 07:22:43 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQgWf-0005Lz-ME for grub-devel@gnu.org; Fri, 01 Jan 2010 07:22:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQgWb-0005Jc-5C for grub-devel@gnu.org; Fri, 01 Jan 2010 07:22:41 -0500 Received: from [199.232.76.173] (port=48854 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQgWb-0005JZ-0G for grub-devel@gnu.org; Fri, 01 Jan 2010 07:22:37 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:44793 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NQgWa-0007Xe-Iw for grub-devel@gnu.org; Fri, 01 Jan 2010 07:22:36 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NQgWZ-0005wh-7I for grub-devel@gnu.org; Fri, 01 Jan 2010 13:22:35 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NQgWY-0002Gk-ER for grub-devel@gnu.org; Fri, 01 Jan 2010 13:22:34 +0100 Date: Fri, 1 Jan 2010 13:22:34 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20100101122234.GN3692@thorin> References: <20091228011737.GA17321@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091228011737.GA17321@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] spaces (label, UUID) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2010 12:22:42 -0000 On Mon, Dec 28, 2009 at 02:17:37AM +0100, Carles Pina i Estany wrote: > === modified file 'normal/misc.c' > --- normal/misc.c 2009-12-20 23:32:15 +0000 > +++ normal/misc.c 2009-12-28 01:15:34 +0000 > @@ -68,7 +68,10 @@ grub_normal_print_device_info (const cha > if (grub_errno == GRUB_ERR_NONE) > { > if (label && grub_strlen (label)) > - grub_printf_ (N_("- Label %s"), label); > + { > + grub_putchar (' '); > + grub_printf_ (N_("- Label \"%s\""), label); > + } > grub_free (label); > } > grub_errno = GRUB_ERR_NONE; > @@ -81,6 +84,7 @@ grub_normal_print_device_info (const cha > if (grub_errno == GRUB_ERR_NONE) > { > grub_unixtime2datetime (tm, &datetime); > + grub_putchar (' '); > grub_printf_ (N_("- Last modification time %d-%02d-%02d " > "%02d:%02d:%02d %s"), > datetime.year, datetime.month, datetime.day, Why not just add a space before the -? Uhm, I guess I know the answer in advance :-) Carles, we shouldn't avoid changing translatable strings at the cost of making the code bigger or less efficient. It's not hard for translators to reuse the old string. I notice that you committed it already. Please can you adjust? -- Robert Millan "Be the change you want to see in the world" -- Gandhi