From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NQk5n-0003V9-Mn for mharc-grub-devel@gnu.org; Fri, 01 Jan 2010 11:11:11 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQk5m-0003Se-29 for grub-devel@gnu.org; Fri, 01 Jan 2010 11:11:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQk5h-0003Iz-7x for grub-devel@gnu.org; Fri, 01 Jan 2010 11:11:09 -0500 Received: from [199.232.76.173] (port=34382 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQk5h-0003Ir-5N for grub-devel@gnu.org; Fri, 01 Jan 2010 11:11:05 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:52486 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NQk5g-000549-NP for grub-devel@gnu.org; Fri, 01 Jan 2010 11:11:05 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NQjnO-0006XY-NB for grub-devel@gnu.org; Fri, 01 Jan 2010 16:52:10 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NQjnN-0000RX-TU for grub-devel@gnu.org; Fri, 01 Jan 2010 16:52:09 +0100 Date: Fri, 1 Jan 2010 16:52:09 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20100101155209.GB1629@thorin> References: <20091228011737.GA17321@pina.cat> <20100101122234.GN3692@thorin> <20100101131051.GA23110@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100101131051.GA23110@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] spaces (label, UUID) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2010 16:11:10 -0000 On Fri, Jan 01, 2010 at 02:10:51PM +0100, Carles Pina i Estany wrote: > > Hi, > > On Jan/01/2010, Robert Millan wrote: > > On Mon, Dec 28, 2009 at 02:17:37AM +0100, Carles Pina i Estany wrote: > > > === modified file 'normal/misc.c' > > > --- normal/misc.c 2009-12-20 23:32:15 +0000 > > > +++ normal/misc.c 2009-12-28 01:15:34 +0000 > > > @@ -68,7 +68,10 @@ grub_normal_print_device_info (const cha > > > if (grub_errno == GRUB_ERR_NONE) > > > { > > > if (label && grub_strlen (label)) > > > - grub_printf_ (N_("- Label %s"), label); > > > + { > > > + grub_putchar (' '); > > > + grub_printf_ (N_("- Label \"%s\""), label); > > > + } > > > Why not just add a space before the -? > > > > Uhm, I guess I know the answer in advance :-) > > I think that you thought about half of the reasons :-) > > > Carles, we shouldn't avoid changing translatable strings at the cost > > of making the code bigger or less efficient. It's not hard for > > translators to reuse the old string. > > This is half of the reason (and not too bad: this translation will > appear as "fuzzy" so it's not everything lost) > > The other reason: > http://lists.gnu.org/archive/html/grub-devel/2009-12/msg00131.html > > Avoiding to have trailing spaces helps the translators (they will do > less mistakes). > > Of course makes the code slightly bigger (source code and binary) Meh, ok. I hope we don't have a lot of these... -- Robert Millan "Be the change you want to see in the world" -- Gandhi