All of lore.kernel.org
 help / color / mirror / Atom feed
From: Holger Hans Peter Freyther <holger+oe@freyther.de>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips
Date: Sat, 2 Jan 2010 09:35:04 +0100	[thread overview]
Message-ID: <201001020935.04959.holger+oe@freyther.de> (raw)
In-Reply-To: <1262417674-26652-1-git-send-email-camelguo@gmail.com>

On Saturday 02 January 2010 08:34:34 Guo Hongruan wrote:
> 1. Add mips entry for linux-uclibc into package_qa_get_machine_dict of
>  insane.bbclass. Without it the insance check will fail due to key miss
>  exception.

>  2. Rewrite the complete qemumips/uClibc.machine, In the
>  previous one, the TARGET_ARCH is set i386 (not mips). ---
>  classes/insane.bbclass                             |    1 +


Please split up the patch as there is no relationship between the two things. 
The first one is a nice catch and I thought we already had this. I can't 
comment on the second one.

The other bit is... use "Signed-off-by:" on your patches if you want them 
included in OE. Only if you use the above they will show up in 
patchwork.openembedded.org which people go through to look at outstanding 
patches...

thanks
	z.!

PS: keep up the nice work :)



  reply	other threads:[~2010-01-02  8:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-02  7:34 [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips Guo Hongruan
2010-01-02  8:35 ` Holger Hans Peter Freyther [this message]
2010-01-02  8:42   ` Guo Hongruan
2010-01-02  9:08     ` signed-off procedure (was: [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips) Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201001020935.04959.holger+oe@freyther.de \
    --to=holger+oe@freyther.de \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.