From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pete Zaitcev <zaitcev@redhat.com>
Subject: Re: [Patch 1/3] tabled: make time2str reentrant
Date: Sun, 3 Jan 2010 01:34:46 -0700
Message-ID: <20100103013446.73b6df4a@redhat.com>
References: <20100103005630.369b3c77@redhat.com>
	<4B40550F.5010907@garzik.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
In-Reply-To: <4B40550F.5010907@garzik.org>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On Sun, 03 Jan 2010 03:27:59 -0500
Jeff Garzik <jeff@garzik.org> wrote:

> > -	sprintf(datestr, "Date: %s", time2str(timestr, time(NULL)));
> > +	sprintf(datestr, "Date: %s", time2str(timestr, 64, time(NULL)));
> 
> applied 1-3, and then added sizeof() to the above time2str calls...  The 
> hardcoded sizes I used for the strings is ugly enough...  let's not add 
> additional "naked numbers" on top of that.

I thought wrapping was worse. Sure...

-- Pete