From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: atomic variable for vis-srv activation
Date: Sun, 3 Jan 2010 03:26:02 +0800 [thread overview]
Message-ID: <201001030326.02365.lindner_marek@yahoo.de> (raw)
In-Reply-To: <20091231033752.GA18781@Sellars>
Hi,
> This fixes the bug discovered by Marek which did not allow turning on
> the vis-server before an interface has been added. This is now being
> done in a similar way as for (de)activating the aggregation mode with an
> atomic variable.
great that you work on this! :)
I'm no expert on the vis code but here my 2 cents:
* You hard-coded integer values instead of using the existing defines. Any
reason for that ?
* my_vis_info->packet.vis_type never gets updated ?
* This patch removes functionality from the /proc parsing function although
this is not related to the patch-topic.
* checkpatch reports 8 errors & 8 warnings
Regards,
Marek
next prev parent reply other threads:[~2010-01-02 19:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 3:37 [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: atomic variable for vis-srv activation =?UTF-8?q?Linus=20L=C3=BCssing?=
2010-01-02 19:26 ` Marek Lindner [this message]
2010-01-05 4:20 ` Linus Lüssing
2010-01-05 7:41 ` Andrew Lunn
2010-01-07 5:23 ` Marek Lindner
2010-01-11 4:57 ` [B.A.T.M.A.N.] [PATCH] " Linus Lüssing
2010-01-13 1:30 ` Linus Lüssing
[not found] ` <201001151124.25877.lindner_marek@yahoo.de>
2010-01-15 18:34 ` Sven Eckelmann
2010-01-15 18:39 ` Sven Eckelmann
2010-01-15 18:50 ` Andrew Lunn
2010-01-18 20:42 ` Linus Lüssing
2010-01-20 2:02 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001030326.02365.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.