From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NRTIt-0004nC-V5 for mharc-grub-devel@gnu.org; Sun, 03 Jan 2010 11:27:44 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRTIr-0004md-IV for grub-devel@gnu.org; Sun, 03 Jan 2010 11:27:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRTIn-0004lc-0c for grub-devel@gnu.org; Sun, 03 Jan 2010 11:27:41 -0500 Received: from [199.232.76.173] (port=34214 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRTIm-0004lZ-U3 for grub-devel@gnu.org; Sun, 03 Jan 2010 11:27:36 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:49141 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NRTIm-0003AJ-9U for grub-devel@gnu.org; Sun, 03 Jan 2010 11:27:36 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NRTIk-0001yS-M2 for grub-devel@gnu.org; Sun, 03 Jan 2010 17:27:34 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NRTIk-00050H-4m for grub-devel@gnu.org; Sun, 03 Jan 2010 17:27:34 +0100 Date: Sun, 3 Jan 2010 17:27:34 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20100103162734.GD27698@thorin> References: <4B37B094.7040102@labri.fr> <4B395C02.9060500@labri.fr> <20100101113953.GC3692@thorin> <4B3F2F90.2020308@labri.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4B3F2F90.2020308@labri.fr> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] grub-probe support for NetBSD X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2010 16:27:42 -0000 On Sat, Jan 02, 2010 at 12:35:44PM +0100, Grégoire Sutre wrote: >> Can you avoid code duplication here? Something like: >> >> #ifdef __NetBSD__ >> const char *template = "%s/r%s"; >> #else >> const char *template = "%s/%s"; >> #endif > > Indeed, it's better. But we also need a variable for the extra length > (3 for NetBSD and 2 otherwise). I have updated the patch. I understand; don't worry about that, GCC is smart and space is cheap in util/ anyway. > http://pkgsrc-wip.cvs.sourceforge.net/viewvc/*checkout*/pkgsrc-wip/wip/grub2-current/patches/patch-grub-probe-netbsd Would you please send patches as attachments? URLs don't make it easy for review. Thanks! -- Robert Millan "Be the change you want to see in the world" -- Gandhi