From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NRTce-0007Gr-Lt for mharc-grub-devel@gnu.org; Sun, 03 Jan 2010 11:48:08 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRTcd-0007Gl-7N for grub-devel@gnu.org; Sun, 03 Jan 2010 11:48:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRTcY-0007EU-BC for grub-devel@gnu.org; Sun, 03 Jan 2010 11:48:06 -0500 Received: from [199.232.76.173] (port=45158 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRTcY-0007E7-5S for grub-devel@gnu.org; Sun, 03 Jan 2010 11:48:02 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:54436 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NRTcX-0001Qa-OH for grub-devel@gnu.org; Sun, 03 Jan 2010 11:48:02 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NRTcW-0002Fk-6i for grub-devel@gnu.org; Sun, 03 Jan 2010 17:48:00 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NRTcV-0005SI-M8 for grub-devel@gnu.org; Sun, 03 Jan 2010 17:47:59 +0100 Date: Sun, 3 Jan 2010 17:47:59 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20100103164759.GF27698@thorin> References: <4B3F42EC.1010100@labri.fr> <20100102153738.GX5847@riva.ucam.org> <4B3F8EA1.7020106@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4B3F8EA1.7020106@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Disable -Werror when error attribute generates warnings X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2010 16:48:07 -0000 On Sat, Jan 02, 2010 at 07:21:21PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > Instead of this, why not only use the attribute if it's available? I > > couldn't find an entry about it in GCC's human-readable change > > summaries, but support was committed on 2007-09-23 so I think it's > > available from GCC 4.3. > > > > =20 > Why not have configure.ac check specifically if this attribute is > available and use it only if it is? Well, yes it'd be better. Although in this case, it's not terribly needed, since we only support GCC and nowadays nobody would use a snapshot from in-between 4.2 and 4.3. -- Robert Millan "Be the change you want to see in the world" -- Gandhi