From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NRTgp-0000zn-KH for mharc-grub-devel@gnu.org; Sun, 03 Jan 2010 11:52:27 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRTgo-0000zF-It for grub-devel@gnu.org; Sun, 03 Jan 2010 11:52:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRTgk-0000x3-1M for grub-devel@gnu.org; Sun, 03 Jan 2010 11:52:26 -0500 Received: from [199.232.76.173] (port=46174 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRTgj-0000wy-Um for grub-devel@gnu.org; Sun, 03 Jan 2010 11:52:21 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:49019 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NRTgj-0002zw-H2 for grub-devel@gnu.org; Sun, 03 Jan 2010 11:52:21 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NRTgh-0002I4-Or for grub-devel@gnu.org; Sun, 03 Jan 2010 17:52:20 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NRTgh-0005TD-3F for grub-devel@gnu.org; Sun, 03 Jan 2010 17:52:19 +0100 Date: Sun, 3 Jan 2010 17:52:19 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20100103165219.GH27698@thorin> References: <4B4006F9.30402@labri.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4B4006F9.30402@labri.fr> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Check for device type (block/character) in grub-setup? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2010 16:52:26 -0000 On Sun, Jan 03, 2010 at 03:54:49AM +0100, Grégoire Sutre wrote: > Hi, > > I'm wondering why there is no check for device type (block/character) in > grub-setup.c whereas the function probe() in grub-probe.c exits with > error if the device is not of the expected type. Shouldn't there be a > similar check in grub-setup? Yes. > I guess that a similar > behavior could be observed on FreeBSD, but I can't actually test this. Please make the code generic if possible (i.e. accept both character and block devices). -- Robert Millan "Be the change you want to see in the world" -- Gandhi