From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] vhost-net: defer f->private_data until setup succeeds
Date: Mon, 4 Jan 2010 13:03:12 +1030
Message-ID: <201001041303.12558.rusty@rustcorp.com.au>
References: <20091222190228.GB2095@sequoia.sous-sol.org> <20091224060650.GA26128@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Chris Wright <chrisw@sous-sol.org>, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:50200 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751701Ab0ADCdw (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 3 Jan 2010 21:33:52 -0500
In-Reply-To: <20091224060650.GA26128@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, 24 Dec 2009 04:36:50 pm Michael S. Tsirkin wrote:
> On Tue, Dec 22, 2009 at 11:02:28AM -0800, Chris Wright wrote:
> > Trivial change, just for readability.  The filp is not installed on
> > failure, so the current code is not incorrect (also vhost_dev_init
> > currently has no failure case).  This just treats setting f->private_data
> > as something with global scope (sure, true only after fd_install).
> > 
> > Signed-off-by: Chris Wright <chrisw@redhat.com>
> 
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

Thanks, applied.

Rusty.