From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix "BUG: using smp_processor_id() in preemptible code"
Date: Mon, 4 Jan 2010 20:20:27 +0530 [thread overview]
Message-ID: <20100104145027.GA2919@debian> (raw)
In-Reply-To: <20100101203544.GG16220@n2100.arm.linux.org.uk>
On Fri, Jan 01, 2010 at 08:35:44PM +0000, Russell King - ARM Linux wrote:
> On Wed, Dec 30, 2009 at 10:47:20PM +0530, Rabin Vincent wrote:
> > Fix the following warning, which appears when the register dump for a
> > faulting process is printed in a kernel with SMP, DEBUG_PREEMPT, and
> > DEBUG_USER (with user_debug=31) enabled:
>
> Well, the CPU number displayed here in preemptible contexts is rather
> meaningless - it doesn't necessarily reflect the CPU where the problem
> originally occurred.
>
> Maybe we should use raw_smp_processor_id() here - which is fine because
> this is just debugging, and it being wrong doesn't cause unsafe
> conditions.
I agree, raw_smp_processor_id() makes more sense here than
{get/put}_cpu(). Revised patch below:
--
next prev parent reply other threads:[~2010-01-04 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 17:17 [PATCH] ARM: fix "BUG: using smp_processor_id() in preemptible code" Rabin Vincent
2010-01-01 20:35 ` Russell King - ARM Linux
2010-01-04 14:50 ` Rabin Vincent [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-12-30 16:58 Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100104145027.GA2919@debian \
--to=rabin@rab.in \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.