From: Florian Fainelli <florian@openwrt.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] VLYNQ: add missing linux/irq.h include
Date: Mon, 4 Jan 2010 21:22:25 +0100 [thread overview]
Message-ID: <201001042122.27360.florian@openwrt.org> (raw)
In-Reply-To: <20100104181228.GA28990@infradead.org>
Hi Christoph,
Le lundi 4 janvier 2010 19:12:28, Christoph Hellwig a écrit :
> On Mon, Jan 04, 2010 at 06:38:51PM +0100, Florian Fainelli wrote:
> > This patch adds the missing linux/irq.h header
> > which will trigger compilation errors on non-AR7
> > platforms (i.e: TI Davinci).
>
> linux/irq.h should not be included by drivers. It's an internal handler
> for the generic hardirq code. All functions for use by drivers are in
> linux/interrupt.h
vlynq.c references definitions that are in linux/irq.h and not in
linux/interrupt.h (like IRQ_TYPE_*), thus the include.
--
Best regards, Florian Fainelli
Email: florian@openwrt.org
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------
prev parent reply other threads:[~2010-01-04 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 17:38 [PATCH] VLYNQ: add missing linux/irq.h include Florian Fainelli
2010-01-04 18:12 ` Christoph Hellwig
2010-01-04 20:22 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001042122.27360.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.