From: Isaku Yamahata <yamahata@valinux.co.jp>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback.
Date: Tue, 5 Jan 2010 14:34:55 +0900 [thread overview]
Message-ID: <20100105053455.GC24491@valinux.co.jp> (raw)
In-Reply-To: <4B4201B2.2070201@redhat.com>
On Mon, Jan 04, 2010 at 03:56:50PM +0100, Gerd Hoffmann wrote:
> On 12/24/09 09:09, Isaku Yamahata wrote:
>> The argument will be used later to remove global variable.
>
>> -static int piix4_device_hotplug(PCIDevice *dev, int state);
>> +static int piix4_device_hotplug(void *opaque, PCIDevice *dev, int state);
>
> You are using that to pass the piix4-pm device state. How about using
> "DeviceState*" instead of "void*" then?
Ok. I'll use DeviceState*.
--
yamahata
next prev parent reply other threads:[~2010-01-05 19:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1261642160-22754-1-git-send-email-yamahata@valinux.co.jp>
[not found] ` <1261642160-22754-2-git-send-email-yamahata@valinux.co.jp>
2010-01-04 14:52 ` [Qemu-devel] Re: [PATCH V10 01/27] acpi: split out pc smbus routines from acpi.c into pc_smbus.c Gerd Hoffmann
[not found] ` <1261642160-22754-23-git-send-email-yamahata@valinux.co.jp>
2010-01-04 14:56 ` [Qemu-devel] Re: [PATCH V10 22/27] pci hotplug: add argument to pci hot plug callback Gerd Hoffmann
2010-01-05 5:34 ` Isaku Yamahata [this message]
2010-01-04 14:59 ` [Qemu-devel] Re: [PATCH V10 00/27] split out piix specific part from pc emulator and some clean ups Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100105053455.GC24491@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.