From: Samuel Ortiz <sameo@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/4] mfd: Don't allow WM8350 to be built modular
Date: Wed, 6 Jan 2010 09:56:21 +0100 [thread overview]
Message-ID: <20100106085620.GA5500@sortiz.org> (raw)
In-Reply-To: <1262724047-4042-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Hi Mark,
On Tue, Jan 05, 2010 at 08:40:47PM +0000, Mark Brown wrote:
> The genirq implementation does not allow modules to implement irq_chips
> so the conversion of WM8350 to genirq means we can no longer allow the
> driver to be built as a module.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>
> Sorry, I thought I'd sent a patch for this earlier but I appear to be
> imagining things.
No problem, patch applied.
Cheers,
Samuel.
> drivers/mfd/Kconfig | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 8782978..1414cec 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -205,7 +205,7 @@ config MFD_WM831X
> functionality of the device.
>
> config MFD_WM8350
> - tristate
> + bool
>
> config MFD_WM8350_CONFIG_MODE_0
> bool
> @@ -256,9 +256,9 @@ config MFD_WM8352_CONFIG_MODE_3
> depends on MFD_WM8350
>
> config MFD_WM8350_I2C
> - tristate "Support Wolfson Microelectronics WM8350 with I2C"
> + bool "Support Wolfson Microelectronics WM8350 with I2C"
> select MFD_WM8350
> - depends on I2C
> + depends on I2C=y
> help
> The WM8350 is an integrated audio and power management
> subsystem with watchdog and RTC functionality for embedded
> --
> 1.6.5.7
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-01-06 8:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 13:57 [PATCH 0/4] Convert WM8350 to genirq Mark Brown
2010-01-05 13:59 ` [PATCH 1/4] mfd: WM8350 off by one bug Mark Brown
2010-01-05 13:59 ` [PATCH 2/4] mfd: Add a data argument to the WM8350 IRQ free function Mark Brown
2010-01-05 13:59 ` [PATCH 3/4] rtc: Suppress duplicate enable/disable of WM8350 update interrupt Mark Brown
2010-01-05 13:59 ` [PATCH 4/4] mfd: Convert WM8350 to genirq Mark Brown
2010-01-05 20:40 ` [PATCH 5/4] mfd: Don't allow WM8350 to be built modular Mark Brown
2010-01-06 8:56 ` Samuel Ortiz [this message]
2010-01-05 15:04 ` [PATCH 3/4] rtc: Suppress duplicate enable/disable of WM8350 update interrupt Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106085620.GA5500@sortiz.org \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.