From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org, Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: Re: question on dapm_reg_event()
Date: Wed, 6 Jan 2010 15:59:17 +0000 [thread overview]
Message-ID: <20100106155917.GA11245@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20100106174859.227f1cd8.jhnikula@gmail.com>
On Wed, Jan 06, 2010 at 05:48:59PM +0200, Jarkko Nikula wrote:
> Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> > Hrm, no, that's not at all clear to me either. CCing Jarkko who
> > contributed the register write control originally.
> IIRC, there were some reason to avoid register update by the
> dapm_update_bits and negative register value was used to prevent it.
> Reg+1 makes sure that the value is negative also for register 0.
Ah, you're using some of the shared fields that the generic widget
handling code then tries to interpret itself. It'd probably be less
surprising to special case this widget in the generic code (as we do in
a few other cases, like the PGA ramping).
prev parent reply other threads:[~2010-01-06 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 2:10 question on dapm_reg_event() Haojian Zhuang
2010-01-06 14:53 ` Mark Brown
2010-01-06 15:48 ` Jarkko Nikula
2010-01-06 15:59 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106155917.GA11245@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=haojian.zhuang@gmail.com \
--cc=jhnikula@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.