From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Matthew Wilcox <matthew@wil.cx>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux@arm.linux.org.uk,
dhowells@redhat.com, ysato@users.sourceforge.jp,
tony.luck@intel.com, geert@linux-m68k.org, zippel@linux-m68k.org,
gerg@uclinux.org, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, jdike@addtoit.com, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com
Subject: Re: [PATCH 1/3] generic sys_old_select
Date: Wed, 6 Jan 2010 17:41:09 +0000 [thread overview]
Message-ID: <20100106174109.GA30528@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100106173438.GA17660@lst.de>
On Wed, Jan 06, 2010 at 06:34:38PM +0100, Christoph Hellwig wrote:
> On Wed, Jan 06, 2010 at 10:32:59AM -0700, Matthew Wilcox wrote:
> > On Wed, Jan 06, 2010 at 06:21:12PM +0100, Christoph Hellwig wrote:
> > > Add a generic implementation of the old select syscall, which expects it's
> > > argument in a memory block and switch all architectures over to use it.
> >
> > Don't we want an ifdef around compat_sys_old_select() like the one
> > around sys_old_select()?
>
> Because nothing in compat.c does it. If we want to bother saving those
> few bites we should do it for more functions, and in a consistant way.
Actually, I'd be a lot happier if we had lib/syscall/old_select.c, instead
of cluttering fs/select.c with that. Objections?
next prev parent reply other threads:[~2010-01-06 17:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 17:21 [PATCH 1/3] generic sys_old_select Christoph Hellwig
2010-01-06 17:32 ` Matthew Wilcox
2010-01-06 17:34 ` Christoph Hellwig
2010-01-06 17:41 ` Al Viro [this message]
2010-01-06 17:47 ` H. Peter Anvin
2010-01-08 9:31 ` Christoph Hellwig
2010-01-08 22:22 ` H. Peter Anvin
2010-01-10 4:49 ` Al Viro
2010-01-06 17:44 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2010-01-08 22:52 Andreas Mohr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106174109.GA30528@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matthew@wil.cx \
--cc=mingo@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=ysato@users.sourceforge.jp \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.