From: Jamie Lokier <jamie@shareable.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: joff@embeddedarm.com, linux-mtd <linux-mtd@lists.infradead.org>,
H Hartley Sweeten <hartleys@visionengravers.com>,
mcrapet@gmail.com,
ARM Kernel <linux-arm-kernel@lists.infradead.org>
Subject: Sending UTF-8 patches (was: [PATCH 2/2] Remove now-defunct ts7250 nand driver)
Date: Wed, 6 Jan 2010 18:07:05 +0000 [thread overview]
Message-ID: <20100106180705.GC11773@shareable.org> (raw)
In-Reply-To: <1262784693.3181.8034.camel@macbook.infradead.org>
David Woodhouse wrote:
> It looks like your patch has legacy garbage in it:
>
> > - * Copyright (C) 2004 Marius Gr<F6>ger (mag@sysgo.de)
>
> It fails to apply because the ö (correctly represented as 0xc3 0xb6) has
> been converted into a single byte 0xf6 in some legacy character set.
>
> When applying patches, git-am does look at the Content-Type: header and
> convert legacy crap into UTF-8 for the changelog, but it leaves the
> patch itself alone.
That's unfortunate. An option to git-am or it's subsidiary tools to
convert the patch as well as the commit would be useful. After all it
_is_ made clear in the MIME header how it's formatted.
> Care to join us in the 21st century?
You mean send the mail in UTF-8 format when it only contains
characters in ISO-8859-1? To make that the default behaviour of an
email sender would possibly violate RFC2045, which as far as I can
tell is still the prevailing standard, which is I guess why Mutt does
not do that in its default configuration, and recodes the text from
UTF-8 to 8859-1 when it can. That's what 21st century tools do :-)
I guess it's time for a "send-hook" to use a different setting
specially for Linux mailing lists.
Do you instead mean send the patch in UTF-8 embedded in a mail encoded
as 8859-1? That sounds quite difficult, if the patch is inline rather
than attached.
An option to git-am to DTRT sounds infinitely better to me. Shame
it's not there; unfortunately it doesn't emit enough information to
make it easy with a wrapper script.
What settings do you use to get this right?
Thanks,
-- Jamie
WARNING: multiple messages have this Message-ID (diff)
From: jamie@shareable.org (Jamie Lokier)
To: linux-arm-kernel@lists.infradead.org
Subject: Sending UTF-8 patches (was: [PATCH 2/2] Remove now-defunct ts7250 nand driver)
Date: Wed, 6 Jan 2010 18:07:05 +0000 [thread overview]
Message-ID: <20100106180705.GC11773@shareable.org> (raw)
In-Reply-To: <1262784693.3181.8034.camel@macbook.infradead.org>
David Woodhouse wrote:
> It looks like your patch has legacy garbage in it:
>
> > - * Copyright (C) 2004 Marius Gr<F6>ger (mag at sysgo.de)
>
> It fails to apply because the ? (correctly represented as 0xc3 0xb6) has
> been converted into a single byte 0xf6 in some legacy character set.
>
> When applying patches, git-am does look at the Content-Type: header and
> convert legacy crap into UTF-8 for the changelog, but it leaves the
> patch itself alone.
That's unfortunate. An option to git-am or it's subsidiary tools to
convert the patch as well as the commit would be useful. After all it
_is_ made clear in the MIME header how it's formatted.
> Care to join us in the 21st century?
You mean send the mail in UTF-8 format when it only contains
characters in ISO-8859-1? To make that the default behaviour of an
email sender would possibly violate RFC2045, which as far as I can
tell is still the prevailing standard, which is I guess why Mutt does
not do that in its default configuration, and recodes the text from
UTF-8 to 8859-1 when it can. That's what 21st century tools do :-)
I guess it's time for a "send-hook" to use a different setting
specially for Linux mailing lists.
Do you instead mean send the patch in UTF-8 embedded in a mail encoded
as 8859-1? That sounds quite difficult, if the patch is inline rather
than attached.
An option to git-am to DTRT sounds infinitely better to me. Shame
it's not there; unfortunately it doesn't emit enough information to
make it easy with a wrapper script.
What settings do you use to get this right?
Thanks,
-- Jamie
next prev parent reply other threads:[~2010-01-06 18:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 21:59 [PATCH 2/2] Remove now-defunct ts7250 nand driver H Hartley Sweeten
2010-01-05 21:59 ` H Hartley Sweeten
2010-01-06 13:31 ` David Woodhouse
2010-01-06 13:31 ` David Woodhouse
2010-01-06 17:26 ` H Hartley Sweeten
2010-01-06 17:26 ` H Hartley Sweeten
2010-01-06 17:42 ` David Woodhouse
2010-01-06 17:42 ` David Woodhouse
2010-01-06 17:47 ` H Hartley Sweeten
2010-01-06 17:47 ` H Hartley Sweeten
2010-05-06 16:47 ` H Hartley Sweeten
2010-05-06 16:47 ` H Hartley Sweeten
2010-05-07 6:01 ` Artem Bityutskiy
2010-05-07 6:01 ` Artem Bityutskiy
2010-05-07 16:37 ` H Hartley Sweeten
2010-05-07 16:37 ` H Hartley Sweeten
2010-01-06 18:07 ` Jamie Lokier [this message]
2010-01-06 18:07 ` Sending UTF-8 patches (was: [PATCH 2/2] Remove now-defunct ts7250 nand driver) Jamie Lokier
2010-01-06 18:36 ` David Woodhouse
2010-01-06 18:36 ` David Woodhouse
2010-01-06 19:01 ` Nicolas Pitre
2010-01-06 19:01 ` Nicolas Pitre
2010-01-06 23:21 ` Jamie Lokier
2010-01-06 23:21 ` Jamie Lokier
2010-01-06 23:43 ` David Woodhouse
2010-01-06 23:43 ` David Woodhouse
2010-01-06 18:55 ` Nicolas Pitre
2010-01-06 18:55 ` Nicolas Pitre
2010-01-06 23:05 ` Jamie Lokier
2010-01-06 23:05 ` Jamie Lokier
2010-01-06 23:08 ` David Woodhouse
2010-01-06 23:08 ` David Woodhouse
2010-01-06 23:27 ` Jamie Lokier
2010-01-06 23:27 ` Jamie Lokier
2010-01-06 23:50 ` David Woodhouse
2010-01-06 23:50 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106180705.GC11773@shareable.org \
--to=jamie@shareable.org \
--cc=dwmw2@infradead.org \
--cc=hartleys@visionengravers.com \
--cc=joff@embeddedarm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mcrapet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.