From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: Scott Wood <scottwood@freescale.com>
Cc: herbert@gondor.apana.org.au, B04825@freescale.com,
linuxppc-dev@ozlabs.org, Vishnu@freescale.com,
Dipen.Dudhat@freescale.com, dan.j.williams@intel.com,
Maneesh.Gupta@freescale.com, R58472@freescale.com
Subject: Re: [PATCH 7/8] fsldma: rename fsl_chan to fchan
Date: Wed, 6 Jan 2010 10:40:55 -0800 [thread overview]
Message-ID: <20100106184055.GD26426@ovro.caltech.edu> (raw)
In-Reply-To: <4B44D5FF.5050505@freescale.com>
On Wed, Jan 06, 2010 at 12:27:11PM -0600, Scott Wood wrote:
> Ira W. Snyder wrote:
> > On Wed, Jan 06, 2010 at 12:04:22PM -0600, Scott Wood wrote:
> >> On Thu, Dec 31, 2009 at 10:10:45PM -0800, Ira W. Snyder wrote:
> >>> The name fsl_chan seems too long, so it has been shortened to fchan.
> >> Could be just "chan", no need for namespacing here.
> >>
> >
> > True. A few functions have a parameter "struct dma_chan *chan" from the
> > DMAEngine API. I tried to keep the name different to avoid confusing
> > readers of the code.
>
> Ah, I see.
>
> I suppose "fchan" is OK in that case, or "priv", or call the dma_chan
> "dchan", etc.
>
Using "priv" is fine with me too, I use that style in a lot of the code
I write. I'll try "chan", and see how it works out.
Ira
next prev parent reply other threads:[~2010-01-06 18:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-01 6:10 fsldma: cleanup driver and fix async_tx compatibility Ira W. Snyder
2010-01-01 6:10 ` [PATCH 1/8] fsldma: reduce kernel text size Ira W. Snyder
2010-01-01 6:10 ` [PATCH 2/8] fsldma: remove unused structure members Ira W. Snyder
2010-01-01 6:10 ` [PATCH 3/8] fsldma: rename struct fsl_dma_chan to struct fsldma_chan Ira W. Snyder
2010-01-01 6:10 ` [PATCH 4/8] fsldma: rename dest to dst for uniformity Ira W. Snyder
2010-01-01 6:10 ` [PATCH 5/8] fsldma: clean up the OF subsystem routines Ira W. Snyder
2010-01-01 6:10 ` [PATCH 6/8] fsldma: simplify IRQ probing and handling Ira W. Snyder
2010-01-06 18:02 ` Scott Wood
2010-01-06 18:39 ` Ira W. Snyder
2010-01-06 20:51 ` Scott Wood
2010-01-01 6:10 ` [PATCH 7/8] fsldma: rename fsl_chan to fchan Ira W. Snyder
2010-01-06 18:04 ` Scott Wood
2010-01-06 18:19 ` Ira W. Snyder
2010-01-06 18:27 ` Scott Wood
2010-01-06 18:40 ` Ira W. Snyder [this message]
2010-01-01 6:10 ` [PATCH 8/8] fsldma: major cleanups and fixes Ira W. Snyder
2010-01-05 6:08 ` fsldma: cleanup driver and fix async_tx compatibility Dudhat Dipen-B09055
2010-01-11 5:47 ` Dudhat Dipen-B09055
2010-01-11 16:29 ` Ira W. Snyder
2010-02-02 7:50 ` Dudhat Dipen-B09055
2010-02-02 15:04 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106184055.GD26426@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=B04825@freescale.com \
--cc=Dipen.Dudhat@freescale.com \
--cc=Maneesh.Gupta@freescale.com \
--cc=R58472@freescale.com \
--cc=Vishnu@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.