From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:55329 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932392Ab0AFUA1 (ORCPT ); Wed, 6 Jan 2010 15:00:27 -0500 Date: Wed, 6 Jan 2010 14:55:03 -0500 From: "John W. Linville" To: Jiri Slaby Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] net: wireless, fix lock imbalance Message-ID: <20100106195503.GB2870@tuxdriver.com> References: <1262795743-15009-1-git-send-email-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1262795743-15009-1-git-send-email-jslaby@suse.cz> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jan 06, 2010 at 05:35:42PM +0100, Jiri Slaby wrote: > One fail path in cfg80211_wext_siwscan omits to unlock rdev->mtx. > Fix that. > > Trigerrable by "Scan for SSID" with long enough SSID (> 32). > > Signed-off-by: Jiri Slaby Both this and the next one are already fixed in wireless-2.6... commit 65486c8b30498dd274eea2c542696f22b63fe5b8 Author: Johannes Berg Date: Wed Dec 23 15:33:35 2009 +0100 cfg80211: fix error path in cfg80211_wext_siwscan If there's an invalid channel or SSID, the code leaks the scan request. Always free the scan request, unless it was successfully given to the driver. Reported-by: Dan Carpenter Signed-off-by: Johannes Berg Acked-by: Dan Carpenter Signed-off-by: John W. Linville -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.