From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NShJB-0000zv-Qw for mharc-grub-devel@gnu.org; Wed, 06 Jan 2010 20:37:05 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NShJA-0000yU-4A for grub-devel@gnu.org; Wed, 06 Jan 2010 20:37:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NShJ5-0000wB-Kf for grub-devel@gnu.org; Wed, 06 Jan 2010 20:37:03 -0500 Received: from [199.232.76.173] (port=48785 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NShJ5-0000w4-Dh for grub-devel@gnu.org; Wed, 06 Jan 2010 20:36:59 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:50232 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NShJ5-0004AE-1u for grub-devel@gnu.org; Wed, 06 Jan 2010 20:36:59 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NShJ0-0006Z7-1N; Thu, 07 Jan 2010 02:36:54 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NShIz-0006XM-Be; Thu, 07 Jan 2010 02:36:53 +0100 Date: Thu, 7 Jan 2010 02:36:53 +0100 From: Robert Millan To: Zhu Yi Message-ID: <20100107013653.GA22169@thorin> References: <1262769004-21960-1-git-send-email-yi.zhu@intel.com> <1262769004-21960-2-git-send-email-yi.zhu@intel.com> <20100106135024.GA2360@thorin> <1262826605.15653.157.camel@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1262826605.15653.157.camel@debian> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: "grub-devel@gnu.org" , Zhu Yi Subject: Re: [PATCH 2/2] Add grub-install --restore option X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 01:37:04 -0000 On Thu, Jan 07, 2010 at 09:10:05AM +0800, Zhu Yi wrote: > > > > Please don't add this to grub-install. This kind of highly BIOS-specific > > logic would suit much better in grub-setup. > > Do you prefer to implement above in C code and add a "--restore" option > to grub-setup or create a separate script for doing this? I think a --restore option to grub-setup would be more appropiate, since the save routine is also there (also, C suits better for this kind of byte mangling IMO). What do others think? -- Robert Millan "Be the change you want to see in the world" -- Gandhi