All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Kagstrom <simon.kagstrom@netinsight.net>
To: Jan Ceuleers <jan.ceuleers@computer.org>
Cc: netdev@vger.kernel.org, "David Miller" <davem@davemloft.net>,
	"Stéphane Berthelot" <sberthelot@emisfr.com>
Subject: Re: [PATCH] via-velocity: add netpoll functionality for the benefit of netconsole
Date: Thu, 7 Jan 2010 07:26:16 +0100	[thread overview]
Message-ID: <20100107072616.4fe2bfb7@marrow.netinsight.se> (raw)
In-Reply-To: <4B439ED5.0@computer.org>

On Tue, 05 Jan 2010 21:19:33 +0100
Jan Ceuleers <jan.ceuleers@computer.org> wrote:

> Simon Kagstrom wrote:
> > Does the patch still work with the new NAPI support in the driver?
> 
> Errr. (Is my ignorance showing yet?)
> 
> I will have to study this, based on other drivers and your commit dfff71.

Well, if you have tested it and netconsole works with the new driver I
would guess it's OK. I don't know netconsole myself, but I know the
interrupt handler (which you call from your patch) has changed with the
NAPI support, so that's why I was wondering if it still worked.

// Simon

  reply	other threads:[~2010-01-07  6:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-04 18:32 [PATCH] via-velocity: add netpoll functionality for the benefit of netconsole Jan Ceuleers
2010-01-05  6:28 ` Simon Kagstrom
2010-01-05 20:19   ` Jan Ceuleers
2010-01-07  6:26     ` Simon Kagstrom [this message]
2010-01-10  9:06       ` Jan Ceuleers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100107072616.4fe2bfb7@marrow.netinsight.se \
    --to=simon.kagstrom@netinsight.net \
    --cc=davem@davemloft.net \
    --cc=jan.ceuleers@computer.org \
    --cc=netdev@vger.kernel.org \
    --cc=sberthelot@emisfr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.