From: Greg KH <gregkh@suse.de>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
ralf@linux-mips.org, linux-mips@linux-mips.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/7] MIPS: Octeon: Fix EIO handling.
Date: Thu, 7 Jan 2010 13:59:50 -0800 [thread overview]
Message-ID: <20100107215950.GA24672@suse.de> (raw)
In-Reply-To: <4B464977.2090801@caviumnetworks.com>
On Thu, Jan 07, 2010 at 12:52:07PM -0800, David Daney wrote:
> Sergei Shtylyov wrote:
>> Hello.
>>
>> David Daney wrote:
>>
>>> If an interrupt handler disables interrupts, the EOI function will
>>> just reenable them. This will put us in an endless loop when the
>>> upcoming Ethernet driver patches are applied.
>>>
>>> Only reenable the interrupt on EOI if it is not IRQ_DISABLED. This
>>> requires that the EIO function be separate from the ENABLE function.
>>> We also rename the ACK functions to correspond with their function.
>>>
>>> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
>>>
>>
>> I guess the subject should read "EIO", not "EIO"...
>>
>
> Indeed. The compiler didn't catch that one.
>
> Perhaps Ralf can fix it if he merges it, otherwise I can resubmit with
> corrected spelling.
I can change it when merging, don't worry about it.
thanks,
greg k-h
next prev parent reply other threads:[~2010-01-07 22:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 19:03 [PATCH 0/7] Staging: Improvments to Octeon Ethernet driver (second attempt) David Daney
2010-01-07 19:05 ` [PATCH 1/7] MIPS: Octeon: Fix EIO handling David Daney
2010-01-07 20:37 ` Sergei Shtylyov
2010-01-07 20:52 ` David Daney
2010-01-07 21:59 ` Greg KH [this message]
2010-01-12 11:36 ` Ralf Baechle
2010-01-12 13:43 ` Greg KH
2010-01-07 19:05 ` [PATCH 2/7] Staging: Octeon Ethernet: Remove unused code David Daney
2010-01-07 19:05 ` [PATCH 3/7] Staging: Octeon Ethernet: Fix memory allocation David Daney
2010-01-07 19:05 ` [PATCH 4/7] Staging: Octeon Ethernet: Rewrite transmit code David Daney
2010-01-07 19:05 ` [PATCH 5/7] Staging: Octeon Ethernet: Convert to NAPI David Daney
2010-01-07 19:05 ` [PATCH 6/7] Staging: Octeon Ethernet: Enable scatter-gather David Daney
2010-01-07 19:05 ` [PATCH 7/7] Staging: Octeon Ethernet: Use constants from in.h David Daney
2010-01-15 7:29 ` Andrew May
2010-01-15 19:41 ` David Daney
2010-01-16 5:44 ` Andrew May
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107215950.GA24672@suse.de \
--to=gregkh@suse.de \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.