From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [PATCH] gpiolib: add gpio_lookup_chip() to get chip information for gpio Date: Fri, 8 Jan 2010 08:28:26 +0000 Message-ID: <20100108082826.GC1224@trinity.fluff.org> References: <1262932348-2888-1-git-send-email-ben-linux@fluff.org> <1262932348-2888-2-git-send-email-ben-linux@fluff.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from trinity.fluff.org ([89.16.178.74]:48224 "EHLO trinity.fluff.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752729Ab0AHI2b (ORCPT ); Fri, 8 Jan 2010 03:28:31 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Eric Miao Cc: Ben Dooks , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Fri, Jan 08, 2010 at 03:30:36PM +0800, Eric Miao wrote: > On Fri, Jan 8, 2010 at 2:32 PM, Ben Dooks wrote: > > Add a call to get the 'struct gpio_chip' pointer for a given gpio, so > > that core implementations which want to use gpiolib gpio numbering for > > things like mux configuration can get back to the gpio_chip that they > > registered without having to have their own list of gpio. > > > > This is especially useful for the Samsung S3C64XX series where the GPIO > > bank sizes can vary from 32 down to 3, making it difficult to store an > > array to convert a number to chip. > > > > I think this is generally a good idea. Will most likely be useful to > pxa platforms as well. Not sure though if you want to export this > symbol as well since we do allow gpio chip drivers to be modules. Probably not, since all the gpio call methods pass gpio_chip as their first parameter. This is only in the case we want to use gpios for something other than in/out/irq. -- Ben Q: What's a light-year? A: One-third less calories than a regular year. From mboxrd@z Thu Jan 1 00:00:00 1970 From: ben-linux@fluff.org (Ben Dooks) Date: Fri, 8 Jan 2010 08:28:26 +0000 Subject: [PATCH] gpiolib: add gpio_lookup_chip() to get chip information for gpio In-Reply-To: References: <1262932348-2888-1-git-send-email-ben-linux@fluff.org> <1262932348-2888-2-git-send-email-ben-linux@fluff.org> Message-ID: <20100108082826.GC1224@trinity.fluff.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 08, 2010 at 03:30:36PM +0800, Eric Miao wrote: > On Fri, Jan 8, 2010 at 2:32 PM, Ben Dooks wrote: > > Add a call to get the 'struct gpio_chip' pointer for a given gpio, so > > that core implementations which want to use gpiolib gpio numbering for > > things like mux configuration can get back to the gpio_chip that they > > registered without having to have their own list of gpio. > > > > This is especially useful for the Samsung S3C64XX series where the GPIO > > bank sizes can vary from 32 down to 3, making it difficult to store an > > array to convert a number to chip. > > > > I think this is generally a good idea. Will most likely be useful to > pxa platforms as well. Not sure though if you want to export this > symbol as well since we do allow gpio chip drivers to be modules. Probably not, since all the gpio call methods pass gpio_chip as their first parameter. This is only in the case we want to use gpios for something other than in/out/irq. -- Ben Q: What's a light-year? A: One-third less calories than a regular year.