From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: reclaim all inodes by background tree walks
Date: Fri, 8 Jan 2010 05:24:08 -0500 [thread overview]
Message-ID: <20100108102408.GB16640@infradead.org> (raw)
In-Reply-To: <1262819125-27083-3-git-send-email-david@fromorbit.com>
Looks safe to me. I wonder whaimpact leaving the inodes around for
longer has to memory usage for inode heavy workloads, though.
> unlock_and_requeue:
> + /*
> + * We could return EAGAIN here to make reclaim rescan the inode tree in
> + * a short while. However, this just burns CPU time scanning the tree
> + * waiting for IO to complete and xfssyncd never goes back to the idle
> + * state. Instead, return 0 to let the next scheduled background reclaim
> + * attempt to reclaim the inode again.
> + */
> xfs_iflags_clear(ip, XFS_IRECLAIM);
> xfs_iunlock(ip, XFS_ILOCK_EXCL);
> - return EAGAIN;
> + return 0;
This is an unrelated change and should be a patch of it's own.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-08 10:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 23:05 [PATCH 0/2] Fix inode reclaim problems (hopefully) Dave Chinner
2010-01-06 23:05 ` [PATCH 1/2] xfs: reclaim inodes under a write lock Dave Chinner
2010-01-08 10:20 ` Christoph Hellwig
2010-01-06 23:05 ` [PATCH 2/2] xfs: reclaim all inodes by background tree walks Dave Chinner
2010-01-08 10:24 ` Christoph Hellwig [this message]
2010-01-08 10:43 ` Dave Chinner
2010-01-07 10:49 ` [PATCH 0/2] Fix inode reclaim problems (hopefully) Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100108102408.GB16640@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.