From: Andreas Gruenbacher <agruen@suse.de>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: git@vger.kernel.org
Subject: Re: base85: Two tiny fixes
Date: Fri, 8 Jan 2010 14:02:02 +0100 [thread overview]
Message-ID: <201001081402.02476.agruen@suse.de> (raw)
In-Reply-To: <alpine.LFD.2.00.1001071253400.21025@xanadu.home>
On Thursday 07 January 2010 18:58:01 Nicolas Pitre wrote:
> ACK. Please post them to this list.
Okay, done.
> On Thu, 7 Jan 2010, Andreas Gruenbacher wrote:
> > There is another little oddity in the way the de85 table is set up: 0
> > indicates an invalid entry; to avoid this from clashing with a valid entry,
> > valid entries are incremented by one and decremented again while decoding.
> > This leads to slightly worse code than using a negative number to indicate
> > invalid values (and avoiding to increment/decrement).
>
> You can make a patch to modify that as well if you wish.
Nah, it's not worth the noise.
> And in that case don't forget to make de85 explicitly signed as a char is
> unsigned by default on some platforms.
I would have forgotten this; thanks for pointing it out!
Thanks,
Andreas
next prev parent reply other threads:[~2010-01-08 13:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 14:58 base85: Two tiny fixes Andreas Gruenbacher
2010-01-07 17:58 ` Nicolas Pitre
2010-01-08 13:02 ` Andreas Gruenbacher [this message]
2010-01-08 13:39 ` [PATCH 1/3] base85 debug code: Fix length byte calculation Andreas Gruenbacher
2010-01-08 13:39 ` [PATCH 2/3] base85: No need to initialize the decode table in encode_85 Andreas Gruenbacher
2010-01-08 15:46 ` Michael J Gruber
2010-01-08 15:55 ` Junio C Hamano
2010-01-08 16:17 ` [PATCH] base85: encode85() does not use the decode table Andreas Gruenbacher
2010-01-08 16:22 ` [PATCH] base85: encode_85() " Andreas Gruenbacher
2010-01-08 13:40 ` [PATCH 3/3] base85: Make the code more obvious instead of explaining the non-obvious Andreas Gruenbacher
2010-01-08 23:15 ` A Large Angry SCM
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001081402.02476.agruen@suse.de \
--to=agruen@suse.de \
--cc=git@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.