From: gdavis@mvista.com (George G. Davis)
To: linux-arm-kernel@lists.infradead.org
Subject: SMP issues on ARM11 MPCore
Date: Fri, 8 Jan 2010 12:44:44 -0500 [thread overview]
Message-ID: <20100108174444.GA824@mvista.com> (raw)
In-Reply-To: <SNT109-W597ECAF29FF35A1CFC84D0A7730@phx.gbl>
Hello Mac Lin,
On Tue, Jan 05, 2010 at 04:02:22PM +0000, mkl lin wrote:
>
>
> > These two sounds like a problem with interrupts - userspace console IO
> > is interrupt driven, whereas kernel console IO is not.
>
> Thanks for Russell's
> advice, after some tracing, I found that my IER (Interrupt Enable
> Register) of the serial port is 0 under case 1!!
>
> Case 2 is
> actually the same with case 1. Case 1 would come first, if I don't keep
> input things and let it finish its slow printing, it would then become
> case 2.
>
> UART_BUG_THRE are detected and enabled on my platform, causing serial8250_backup_timeout to be used.
>
> There
> are many places that do ( get IER, clear IER, restore IER ), like
> serial8250_console_write called by printk, and
> serial8250_backup_timeout. serial8250_backup_timeout is not protected
> by spinlock, causing the race condition, and result in wrong IER value.
>
> Following patch fix this issue. Case 3 and Case 4 are still often seen, but not case 1 and case 2.
>
> Best Regards,
> Mac Lin
> diff --git a/kernels/linux-2.6.31.1-X/drivers/serial/8250.c b/kernels/linux-2.6.31.1-X/drivers/serial/8250.c
> index 288a0e4..55602c3 100644
> --- a/kernels/linux-2.6.31.1-cavm1/drivers/serial/8250.c
> +++ b/kernels/linux-2.6.31.1-cavm1/drivers/serial/8250.c
> @@ -1752,6 +1758,8 @@ static void serial8250_backup_timeout(unsigned long data)
If you still need resolution on the serial8250_backup_timeout problem,
you should probably consider submitting an RFC/PATCH to the
linux-serial at vger.kernel.org or linux-kernel at vger.kernel.org.
--
Regards,
George
next prev parent reply other threads:[~2010-01-08 17:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-24 15:27 SMP issues on ARM11 MPCore mkl lin
2009-12-24 20:11 ` Dirk Behme
2009-12-25 3:13 ` mkl lin
2010-01-01 20:58 ` Russell King - ARM Linux
2010-01-03 8:56 ` mkl lin
2010-01-03 17:29 ` mkl lin
2010-01-05 16:02 ` mkl lin
2010-01-08 17:44 ` George G. Davis [this message]
2010-01-07 10:50 ` Dirk Behme
2010-01-07 13:45 ` Dirk Behme
2010-01-07 14:13 ` Russell King - ARM Linux
2010-01-07 14:39 ` Uwe Kleine-König
2010-01-08 13:14 ` Dirk Behme
2010-01-08 15:09 ` mkl lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100108174444.GA824@mvista.com \
--to=gdavis@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.