From: Johannes Sixt <j6t@kdbg.org>
To: kusmabite@gmail.com
Cc: Dmitry Potapov <dpotapov@gmail.com>,
msysgit <msysgit@googlegroups.com>,
git@vger.kernel.org,
"Andrzej K. Haczewski" <ahaczewski@gmail.com>
Subject: Re: [PATCH 1/5] MSVC: Windows-native implementation for subset of Pthreads API
Date: Fri, 8 Jan 2010 21:40:36 +0100 [thread overview]
Message-ID: <201001082140.36717.j6t@kdbg.org> (raw)
In-Reply-To: <40aa078e1001080258n67e0711sf4733a99d512bf1@mail.gmail.com>
On Freitag, 8. Januar 2010, Erik Faye-Lund wrote:
> On Fri, Jan 8, 2010 at 4:32 AM, Dmitry Potapov <dpotapov@gmail.com> wrote:
> > AFAIK, Win32 API assumes that reading LONG is always atomic, so
> > the critical section is not really necesary here, but you need
> > to declare 'waiters' as 'volatile':
>
> "Simple reads and writes to properly-aligned 32-bit variables are
> atomic operations."
> http://msdn.microsoft.com/en-us/library/ms684122(VS.85).aspx
>
> In other words: Yes, you are right.
Quite frankly, I do not want to stretch this statement to apply to the MinGW
compiler. The code in question is not performance critical anyway. I'd prefer
to leave it as is - it's undergone 2 months of testing already. Besides,
IMHO, it is much more readable the way it is written.
-- Hannes
next prev parent reply other threads:[~2010-01-08 20:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 21:54 [PATCH 0/5] Miscellaneous improvements on Windows Johannes Sixt
2010-01-07 21:54 ` [PATCH 1/5] MSVC: Windows-native implementation for subset of Pthreads API Johannes Sixt
2010-01-08 3:32 ` Dmitry Potapov
2010-01-08 10:58 ` Erik Faye-Lund
2010-01-08 20:40 ` Johannes Sixt [this message]
2010-01-08 21:37 ` Dmitry Potapov
2010-01-12 21:13 ` Johannes Sixt
2010-01-13 12:53 ` Dmitry Potapov
2010-01-13 18:40 ` Johannes Sixt
2010-01-14 5:12 ` Dmitry Potapov
2010-01-14 13:43 ` Peter Harris
2010-01-14 19:55 ` Johannes Sixt
2010-01-07 21:54 ` [PATCH 2/5] MinGW: enable pthreads Johannes Sixt
2010-01-07 21:54 ` [PATCH 3/5] Windows: boost startup by avoiding a static dependency on shell32.dll Johannes Sixt
2010-01-07 21:55 ` [PATCH 4/5] Windows: simplify the pipe(2) implementation Johannes Sixt
2010-01-07 21:55 ` [PATCH 5/5] Windows: avoid the "dup dance" when spawning a child process Johannes Sixt
2010-01-15 20:12 ` [PATCH v2 0/7] Miscellaneous improvements on Windows Johannes Sixt
2010-01-15 20:12 ` [PATCH v2 1/7] Windows: disable Python Johannes Sixt
2010-01-15 20:12 ` [PATCH v2 2/7] Windows: boost startup by avoiding a static dependency on shell32.dll Johannes Sixt
2010-01-15 20:12 ` [PATCH v2 3/7] Windows: simplify the pipe(2) implementation Johannes Sixt
2010-01-15 20:12 ` [PATCH v2 4/7] Windows: avoid the "dup dance" when spawning a child process Johannes Sixt
2010-01-15 20:12 ` [PATCH v2 5/7] MSVC: Fix an "incompatible pointer types" compiler warning Johannes Sixt
2010-01-15 20:12 ` [PATCH v2 6/7] MSVC: Windows-native implementation for subset of Pthreads API Johannes Sixt
2010-01-15 20:12 ` [PATCH v2 7/7] Do not use date.c:tm_to_time_t() from compat/mingw.c Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001082140.36717.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=ahaczewski@gmail.com \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.