All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: "Németh Márton" <nm127@freemail.hu>,
	devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>,
	"Julia Lawall" <julia@diku.dk>,
	cocci@diku.dk
Subject: Re: [PATCH 1/3] staging: make PCI device id constant
Date: Sat, 9 Jan 2010 15:43:05 -0800	[thread overview]
Message-ID: <20100109234304.GA6168@suse.de> (raw)
In-Reply-To: <20100109154115.152c55e1@infradead.org>

On Sat, Jan 09, 2010 at 03:41:15PM -0800, Arjan van de Ven wrote:
> On Sun, 10 Jan 2010 00:18:26 +0100
> Németh Márton <nm127@freemail.hu> wrote:
> 
> > From: Márton Németh <nm127@freemail.hu>
> > 
> > The id_table field of the struct pci_driver is constant in
> > <linux/pci.h> so it is worth to make the initialization data also
> > constant.
> 
> 
> the PCI ID table can get written too via sysfs... making it const
> breaks that...

It shouldn't, I thought that was what we used the dynids field in the
pci_driver structure :)

thanks,

greg k-h

  reply	other threads:[~2010-01-09 23:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-09 23:18 [PATCH 1/3] staging: make PCI device id constant Németh Márton
2010-01-09 23:41 ` Arjan van de Ven
2010-01-09 23:43   ` Greg KH [this message]
2010-01-15  1:36 ` patch staging-make-pci-device-id-constant.patch added to gregkh-2.6 tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100109234304.GA6168@suse.de \
    --to=gregkh@suse.de \
    --cc=arjan@infradead.org \
    --cc=cocci@diku.dk \
    --cc=devel@driverdev.osuosl.org \
    --cc=julia@diku.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm127@freemail.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.