Re: IR device at I2C address 0x7a

[Jean Delvare <khali@linux-fr.org>]

On Sun, 10 Jan 2010 00:18:46 +0100, hermann pitton wrote:
> Hi,
> 
> Am Samstag, den 09.01.2010, 17:14 +0100 schrieb Jean Delvare:
> > On Sat, 09 Jan 2010 13:08:36 +0100, Daro wrote:
> > > W dniu 06.01.2010 21:21, Jean Delvare pisze:
> > > > On Wed, 06 Jan 2010 18:58:58 +0100, Daro wrote:
> > > >> It is not the error message itself that bothers me but the fact that IR
> > > >> remote control device is not detected and I cannot use it (I checked it
> > > >> on Windows and it's working). After finding this thread I thought it
> > > >> could have had something to do with this error mesage.
> > > >> Is there something that can be done to get my IR remote control working?
> > > > You could try loading the saa7134 driver with option card=146 and see
> > > > if it helps.
> > >
> > > It works!
> > > 
> > > [   15.477875] input: saa7134 IR (ASUSTeK P7131 Analo as 
> > > /devices/pci0000:00/0000:00:1e.0/0000:05:00.0/input/input8
> > > 
> > > Thank you very much fo your help.
> > 
> > Then I would suggest the following patch:
> > 
> > * * * * *
> > 
> > From: Jean Delvare <khali@linux-fr.org>
> > Subject: saa7134: Fix IR support of some ASUS TV-FM 7135 variants
> > 
> > Some variants of the ASUS TV-FM 7135 are handled as the ASUSTeK P7131
> > Analog (card=146). However, by the time we find out, some
> > card-specific initialization is missed. In particular, the fact that
> > the IR is GPIO-based. Set it when we change the card type.
> > 
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Tested-by: Daro <ghost-rider@aster.pl>
> 
> just to note it, the ASUS TV-FM 7135 with USB remote is different to the
> Asus My Cinema P7134 Analog only, not only for the remote, but also for
> inputs, but they have the same PCI subsystem.
> 
> > ---
> >  linux/drivers/media/video/saa7134/saa7134-cards.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- v4l-dvb.orig/linux/drivers/media/video/saa7134/saa7134-cards.c	2009-12-11 09:47:47.000000000 +0100
> > +++ v4l-dvb/linux/drivers/media/video/saa7134/saa7134-cards.c	2010-01-09 16:23:17.000000000 +0100
> > @@ -7257,6 +7257,7 @@ int saa7134_board_init2(struct saa7134_d
> >  		       printk(KERN_INFO "%s: P7131 analog only, using "
> >  						       "entry of %s\n",
> >  		       dev->name, saa7134_boards[dev->board].name);
> > +			dev->has_remote = SAA7134_REMOTE_GPIO;
> >  	       }
> >  	       break;
> >  	case SAA7134_BOARD_HAUPPAUGE_HVR1150:
> > 
> > 
> > * * * * *
> 
> Must have been broken at that time, IIRC.

What must have been broken, and when? You are confusing.

> Only moving saa7134_input_init1(dev) to static int saa7134_hwinit2
> in saa7134-core.c did help, AFAIK, but I might be wrong.

I admit I don't quite get why dev->has_remove should be set early (in
saa7134_board_init1) given that for one board
(SAA7134_BOARD_FLYDVB_TRIO) it is set later (in saa7134_board_init2)
and apparently it works OK. It would make more sense to do it at the
same time for all boards IMHO, possibly in a separate function to make
it clearer.

I am also curious if it wouldn't be even clearer and more efficient to
store the default value of has_remote in struct saa7134_board. As far
as I can see, only the SAA7134_BOARD_FLYDVB_TRIO needs a run-time check.

-- 
Jean Delvare