From: Dave Chinner <david@fromorbit.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Allow linker to eliminate unused functions in lib/*
Date: Mon, 11 Jan 2010 10:17:08 +1100 [thread overview]
Message-ID: <20100110231708.GC4019@discord.disaster> (raw)
In-Reply-To: <20100109165155.GD20773@basil.fritz.box>
On Sat, Jan 09, 2010 at 05:51:56PM +0100, Andi Kleen wrote:
> > Sneaky.
> >
> > It's a bit sad to reduce the code cleanliness and maintainability in
> > this way, but 1k is 1k.
>
> Yes. I had actually hoped for more too. I think it might bring
> more with -ffunction-sections/--gc-sections, but I haven't tried that.
>
> An alternative might be also to give some more of those explicit Kconfig
> symbols -- then kernels with module loading enabled would benefit more
> too -- but I haven't investigated how many changes that would need.
>
> But even with that it's a reasonable improvement and putting the exports
> separately is not too bad.
>
> > The patch assumes a pre-existing lib-syms.c. Confused.
>
> Sorry, some day I'll learn how to operate quilt properly.
>
> Updated patch with all files included appended.
Andi, how do you want to handle the overlap between this and the
list_sort() patch I sent? I'm going to need a list_sort() available
in the XFS tree well before the 2.6.34 merge window....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2010-01-10 23:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 14:59 [PATCH] Allow linker to eliminate unused functions in lib/* Andi Kleen
2010-01-09 0:29 ` Andrew Morton
2010-01-09 16:51 ` Andi Kleen
2010-01-10 23:17 ` Dave Chinner [this message]
2010-01-11 10:51 ` Christoph Hellwig
2010-01-11 14:24 ` Andi Kleen
2010-01-11 22:49 ` Dave Chinner
2010-01-15 23:44 ` Andrew Morton
2010-01-16 11:07 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100110231708.GC4019@discord.disaster \
--to=david@fromorbit.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.