From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Glisse Subject: Re: ttm_flag_masked in ttm_bo_util.c Date: Mon, 11 Jan 2010 12:48:34 +0100 Message-ID: <20100111114834.GA3499@localhost.localdomain> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net To: "Yuan, Shengquan" Cc: dri-devel@lists.sf.net List-Id: dri-devel@lists.freedesktop.org On Mon, Jan 11, 2010 at 04:20:00PM +0800, Yuan, Shengquan wrote: > In function ttm_bo_move_ttm, ttm_bo_move_memcpy, and > ttm_bo_move_accel_cleanup, just before function exits, there is: > ttm_flag_masked(&save_flags, new_mem->placement, > TTM_PL_MASK_MEMTYPE); > > Is it needed because save_flags is just a local variable? > > Thanks > Austin Looks like dead code, likely left over of some cut & paste :) If Thomas confirms i think you can propose a patch to nuke those. Cheers, Jerome ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev --