All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: mingo@elte.hu
Cc: aris@redhat.com, linux-kernel@vger.kernel.org
Subject: introduce NMI_AUTO as nmi_watchdog option
Date: Mon, 11 Jan 2010 14:16:33 -0500	[thread overview]
Message-ID: <20100111191633.GT24885@redhat.com> (raw)

Hi Ingo,

To dig up an old thread last November:

======
* Aristeu Rozanski <aris@redhat.com> wrote:

> > > > > NMI_AUTO is a new nmi_watchdog option that makes LAPIC be tried
> > > > > first 
> > > > > and if the CPU isn't supported, IOAPIC will be used. It's useful
> > > > > in 
> > > > > cases where NMI watchdog is enabled by default in a kernel built
> > > > > for 
> > > > > different machines. It can be configured by default or selected
> > > > > with 
> > > > > nmi_watchdog=3 or nmi_watchdog=auto parameters.
> > > > 
> > > > What i'd like to see for the NMI watchdog is much more ambitious
> > > > than 
> > > > this: the use of perf events to run a periodic NMI callback.
> > > > 
> > > > The NMI watchdog would cause the creation of a per-cpu perf_event 
> > > > structure (in-kernel). All x86 CPUs that have perf event support
> > > > (the 
		> > > > majority of them) will thus be able to have an NMI
> > > > watchdog using a 
> > > > nice, generic piece of code and we'd be able to phase out the
> > > > open-coded 
> > > > NMI watchdog code.
> > > > 
> > > > The user would not notice much from this: we'd still have the 
> > > > /proc/sys/kernel/nmi_watchdog toggle to turn it on/off, and we'd
> > > > still 
> > > > have the nmi_watchog= boot parameter as well. But the underlying 
> > > > implementation would be far more generic and far more usable than
> > > > the 
> > > > current code.
> > > > 
> > > > Would you be interested in moving the NMI watchdog code in this 
> > > > direction? Most of the perf events changes (callbacks, helpers for 
		> > > > in-kernel event allocations, etc.) are in latest
> > > > -tip already, so you 
> > > > could use that as a base.
> > >
> > > but that would work only for LAPIC. You're suggesting killing IOAPIC 
> > > mode too?
> > 
> > Would it be a big loss, with all modern systems expected to have a 
> > working lapic based NMI source? I wrote the IOAPIC mode originally but
> > i 
> > dont feel too attached to it ;-)
>
> ok, fair enough. but since it'll be another implementation, do you 
> mind applying the patches I submitted so they can be used until the 
> new implementation is in place?

For that i need to see at least an RFC v1 version series of the new 
implementation - otherwise we might end up sitting on this interim 
version with no-one doing the better variant.

========

I was going to jump in and try to do this work.  I wanted to make sure
what you were looking for here.  When you say convert nmi watchdog to perf
events, I assume you mean merging over the bits of perfctr-watchdog.c to
perf_events.c, modify nmi.c to just register as a normal perf event and
probably cleanup the oprofile stuff to match, correct?

Cheers,
Don


             reply	other threads:[~2010-01-11 19:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-11 19:16 Don Zickus [this message]
2010-01-11 20:27 ` introduce NMI_AUTO as nmi_watchdog option Cyrill Gorcunov
2010-01-11 20:33   ` Don Zickus
2010-01-11 20:51     ` Cyrill Gorcunov
2010-01-13  9:32     ` Ingo Molnar
2010-01-13 13:13       ` Peter Zijlstra
2010-01-13 16:25         ` Don Zickus
2010-01-13 16:42           ` Peter Zijlstra
2010-01-13 16:35         ` Ingo Molnar
2010-01-13 16:23       ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100111191633.GT24885@redhat.com \
    --to=dzickus@redhat.com \
    --cc=aris@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.