From: Pavel Vasilyev <pavel@pavlinux.ru>
To: linux-kernel@vger.kernel.org,
drivers_staging@kernel-bugs.osdl.org, greg@kroah.com
Subject: [PATCH] HTC Dream camera, not need sizeof
Date: Mon, 11 Jan 2010 21:08:02 +0300 [thread overview]
Message-ID: <201001112108.02634.pavel@pavlinux.ru> (raw)
http://bugzilla.kernel.org/show_bug.cgi?id=14825
Kernel version: git master (2.6.33-rc3-git3)
Description:
sizeof(extlen), always will be sizeof( unit32_t) or 4
It seems that something is wrong?!?!
-------
diff --git a/drivers/staging/dream/camera/msm_vfe7x.c
b/drivers/staging/dream/camera/msm_vfe7x.c
index 33ab3ac..4d39848 100644
--- a/drivers/staging/dream/camera/msm_vfe7x.c
+++ b/drivers/staging/dream/camera/msm_vfe7x.c
@@ -256,7 +256,7 @@ static int vfe_7x_init(struct msm_vfe_callback *presp,
extlen = sizeof(struct vfe_frame_extra);
extdata =
- kmalloc(sizeof(extlen), GFP_ATOMIC);
+ kmalloc(extlen, GFP_ATOMIC);
if (!extdata) {
rc = -ENOMEM;
goto init_fail;
----
next reply other threads:[~2010-01-11 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 18:08 Pavel Vasilyev [this message]
2010-01-11 18:47 ` [PATCH] HTC Dream camera, not need sizeof Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001112108.02634.pavel@pavlinux.ru \
--to=pavel@pavlinux.ru \
--cc=drivers_staging@kernel-bugs.osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.