From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
linux-fsdevel@vger.kernel.org, Trond.Myklebust@netapp.com,
dhowells@redhat.com
Subject: Re: [PATCH 1/2] make sure data is on disk before calling ->write_inode
Date: Tue, 12 Jan 2010 11:41:03 +1100 [thread overview]
Message-ID: <20100112004103.GC16080@discord.disaster> (raw)
In-Reply-To: <20100111173047.GA6852@lst.de>
On Mon, Jan 11, 2010 at 06:30:47PM +0100, Christoph Hellwig wrote:
> Similar to the fsync issue fixed a while ago in commit
> 2daea67e966dc0c42067ebea015ddac6834cef88 we need to write for data to
> actually hit the disk before writing out the metadata to guarantee
> data integrity for filesystems that modify the inode in the data I/O
> completion path. Currently XFS and NFS handle this manually, and AFS
> has a write_inode method that does nothing but waiting for data, while
> others are possibly missing out on this.
>
> Fortunately this change has a lot less impact than the fsync change
> as none of the write_inode methods starts data writeout of any form
> by itself.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
The generic and XFS bits look OK to me.
Acked-by: Dave Chinner <david@fromrobit.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2010-01-12 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 17:30 [PATCH 1/2] make sure data is on disk before calling ->write_inode Christoph Hellwig
2010-01-12 0:41 ` Dave Chinner [this message]
2010-01-14 0:21 ` Andrew Morton
2010-01-14 6:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112004103.GC16080@discord.disaster \
--to=david@fromorbit.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.