From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 1/2] make sure data is on disk before calling ->write_inode Date: Tue, 12 Jan 2010 11:41:03 +1100 Message-ID: <20100112004103.GC16080@discord.disaster> References: <20100111173047.GA6852@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, Trond.Myklebust@netapp.com, dhowells@redhat.com To: Christoph Hellwig Return-path: Received: from bld-mail17.adl2.internode.on.net ([150.101.137.102]:40567 "EHLO mail.internode.on.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751172Ab0ALAle (ORCPT ); Mon, 11 Jan 2010 19:41:34 -0500 Content-Disposition: inline In-Reply-To: <20100111173047.GA6852@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jan 11, 2010 at 06:30:47PM +0100, Christoph Hellwig wrote: > Similar to the fsync issue fixed a while ago in commit > 2daea67e966dc0c42067ebea015ddac6834cef88 we need to write for data to > actually hit the disk before writing out the metadata to guarantee > data integrity for filesystems that modify the inode in the data I/O > completion path. Currently XFS and NFS handle this manually, and AFS > has a write_inode method that does nothing but waiting for data, while > others are possibly missing out on this. > > Fortunately this change has a lot less impact than the fsync change > as none of the write_inode methods starts data writeout of any form > by itself. > > Signed-off-by: Christoph Hellwig The generic and XFS bits look OK to me. Acked-by: Dave Chinner -- Dave Chinner david@fromorbit.com