From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUdnI-0000BN-UB for qemu-devel@nongnu.org; Tue, 12 Jan 2010 05:16:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUdnE-0000AV-5y for qemu-devel@nongnu.org; Tue, 12 Jan 2010 05:16:12 -0500 Received: from [199.232.76.173] (port=40149 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUdnE-0000AS-40 for qemu-devel@nongnu.org; Tue, 12 Jan 2010 05:16:08 -0500 Received: from verein.lst.de ([213.95.11.210]:60719) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1NUdnD-0006bw-GO for qemu-devel@nongnu.org; Tue, 12 Jan 2010 05:16:08 -0500 Date: Tue, 12 Jan 2010 11:16:02 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] raw-posix: Detect IDE floppy via ioctl Message-ID: <20100112101602.GA10900@lst.de> References: <1263234619-14522-2-git-send-email-crobinso@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1263234619-14522-2-git-send-email-crobinso@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: qemu-devel@nongnu.org On Mon, Jan 11, 2010 at 01:30:19PM -0500, Cole Robinson wrote: > Current IDE floppy detection is hardcoded based on source file name. > Make this smarter by attempting a floppy specific ioctl. IDE floppys show up as /dev/hd?, these are old legacy floppies. Otherwise looks good except that I think the ioctl should have a higher match priority than the name match. Same applies to the CDROM version of the patch.