From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Kay Sievers <kay.sievers@vrfy.org>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
linux-fsdevel@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>,
Benjamin LaHaise <bcrl@lhnet.ca>, Serge Hallyn <serue@us.ibm.com>,
"Eric W. Biederman" <ebiederm@aristanetworks.com>
Subject: Re: [PATCH 3/7] sysfs: Keep an nlink count on sysfs directories.
Date: Tue, 12 Jan 2010 13:41:34 +0100 [thread overview]
Message-ID: <20100112134134.5f55e95f@gondolin> (raw)
In-Reply-To: <1263241315-19499-3-git-send-email-ebiederm@xmission.com>
On Mon, 11 Jan 2010 12:21:51 -0800,
"Eric W. Biederman" <ebiederm@xmission.com> wrote:
> From: Eric W. Biederman <ebiederm@aristanetworks.com>
>
> On large directories sysfs_count_nlinks can be a significant
> bottleneck, so keep a count in sysfs_dirent. If we exceed
> the maximum number of directory entries we can store return
> nlink of 1. An nlink of 1 matches what reiserfs does in
> this case, and it let's find and similar utlities know that
> we have a the directory nlink can not be used for optimization
> purposes.
>
> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
> ---
> fs/sysfs/dir.c | 20 ++++++++++++++++++++
> fs/sysfs/inode.c | 15 +--------------
> fs/sysfs/mount.c | 1 +
> fs/sysfs/sysfs.h | 1 +
> 4 files changed, 23 insertions(+), 14 deletions(-)
>
> @@ -420,6 +438,7 @@ int __sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
> return -EEXIST;
>
> sd->s_parent = sysfs_get(acxt->parent_sd);
> + sysfs_dir_inc_nlink(sd->s_parent);
>
> sysfs_link_sibling(sd);
>
> @@ -512,6 +531,7 @@ void sysfs_remove_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
>
> BUG_ON(sd->s_flags & SYSFS_FLAG_REMOVED);
>
> + sysfs_dir_dec_nlink(sd->s_parent);
> sysfs_unlink_sibling(sd);
>
> /* Update timestamps on the parent */
Shouldn't s_nlink be adjusted in sysfs_rename for the move case as well?
next prev parent reply other threads:[~2010-01-12 12:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 20:16 [PATCH 0/7] General sysfs enhancements Eric W. Biederman
2010-01-11 20:21 ` [PATCH 1/7] sysfs: Serialize updates to the vfs inode Eric W. Biederman
2010-01-12 5:41 ` Serge E. Hallyn
2010-01-11 20:21 ` [PATCH 2/7] sysfs: Pack sysfs_dirent more tightly Eric W. Biederman
2010-01-12 0:41 ` Tejun Heo
2010-01-11 20:21 ` [PATCH 3/7] sysfs: Keep an nlink count on sysfs directories Eric W. Biederman
2010-01-12 0:46 ` Tejun Heo
2010-01-12 0:53 ` Benjamin LaHaise
2010-01-12 1:06 ` Eric W. Biederman
2010-01-12 1:12 ` Benjamin LaHaise
2010-01-12 1:23 ` Eric W. Biederman
2010-01-12 6:22 ` Tejun Heo
2010-01-12 15:49 ` Valdis.Kletnieks
2010-01-12 1:02 ` Eric W. Biederman
2010-01-12 5:56 ` Serge E. Hallyn
2010-01-12 8:30 ` Eric W. Biederman
2010-01-12 12:41 ` Cornelia Huck [this message]
2010-01-12 15:34 ` Eric W. Biederman
2010-01-11 20:21 ` [PATCH 4/7] sysfs: Implement sysfs_rename_link Eric W. Biederman
2010-01-12 6:24 ` Tejun Heo
2010-01-12 17:30 ` Serge E. Hallyn
2010-01-11 20:21 ` [PATCH 5/7] driver core: Use sysfs_rename_link in device_rename Eric W. Biederman
2010-01-12 6:25 ` Tejun Heo
2010-01-12 17:34 ` Serge E. Hallyn
2010-01-11 20:21 ` [PATCH 6/7] sysfs: Pass super_block to sysfs_get_inode Eric W. Biederman
2010-01-12 17:43 ` Serge E. Hallyn
2010-01-11 20:21 ` [PATCH 7/7] sysfs: Kill unused sysfs_sb variable Eric W. Biederman
2010-01-12 17:43 ` Serge E. Hallyn
2010-01-15 21:37 ` [PATCH 0/7] General sysfs enhancements Greg KH
2010-02-13 3:20 ` [PATCH 0/6] " Eric W. Biederman
2010-02-13 3:22 ` [PATCH 1/6] sysfs: Serialize updates to the vfs inode Eric W. Biederman
2010-02-13 3:22 ` [PATCH 2/6] sysfs: Pack sysfs_dirent more tightly Eric W. Biederman
2010-02-13 3:22 ` [PATCH 3/6] sysfs: Implement sysfs_rename_link Eric W. Biederman
2010-02-13 3:22 ` [PATCH 4/6] driver core: Use sysfs_rename_link in device_rename Eric W. Biederman
2010-02-13 3:22 ` [PATCH 5/6] sysfs: Pass super_block to sysfs_get_inode Eric W. Biederman
2010-02-13 3:22 ` [PATCH 6/6] sysfs: Kill unused sysfs_sb variable Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112134134.5f55e95f@gondolin \
--to=cornelia.huck@de.ibm.com \
--cc=bcrl@lhnet.ca \
--cc=ebiederm@aristanetworks.com \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.