From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] fixing cpg names in 3.0.8?
Date: Tue, 12 Jan 2010 10:24:46 -0600 [thread overview]
Message-ID: <20100112162445.GA24645@redhat.com> (raw)
I just discovered that the cpg group names that fenced, dlm_controld and
gfs_controld use in cluster3 include a nul within the name length. This
can happen because cpg names have both a string part and a length part,
and the length is currently being set to strlen + 1 instead of strlen.
It's harmless since all the code is making the same mistake, but it's an
obvious flaw.
You can easily see this by the trailing \x00 from corosync-cpgtool,
fenced:default\x00
If we fixed the length of the names, it would break internode
compatibility between 3.0.7 and 3.0.8 releases, e.g.
"fenced:default\x00" and "fenced:default" are two different groups.
AFAIK we're not yet guaranteeing rolling upgrade compatibility from one
3.0 release to the next, so I think I should go ahead and fix this, unless
anyone feels strongly otherwise?
Dave
next reply other threads:[~2010-01-12 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 16:24 David Teigland [this message]
2010-01-12 16:00 ` [Cluster-devel] fixing cpg names in 3.0.8? Christine Caulfield
2010-01-12 17:16 ` David Teigland
2010-01-12 16:55 ` Jan Friesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112162445.GA24645@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.