From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: build fixes Date: Tue, 12 Jan 2010 18:31:24 +0100 Message-ID: <201001121831.25212.Christoph.Egger@amd.com> References: <201001111258.26274.Christoph.Egger@amd.com> <19276.44985.149108.19729@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19276.44985.149108.19729@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tuesday 12 January 2010 18:22:01 Ian Jackson wrote: > Christoph Egger writes ("[Xen-devel] build fixes"): > > Attached patch fixes Xen build on NetBSD. > > Nack. ? > > +#include /* for pid_t */ > > This is fine but should read: > #include > as there is no point putting > /* for somethingorother */ > after every #include. > > > - if (!isdigit(p[i])) { > > + if (!isdigit((uint8_t)p[i])) { > > This is correct on all platforms. But it should be fixed by some more > general approach, as it's needed for almost every call to a ctype > macro. Any suggestions ? > > - seek_ret = lseek64(fd, i << PAGE_SHIFT, SEEK_SET); > > + seek_ret = lseek(fd, i << PAGE_SHIFT, SEEK_SET); > > This is just wrong. It will break on >2G files. No, lseek64() doesn't exist. lseek() works fine on files > 2GB on NetBSD. I think, on Linux you need to define LARGEFILES or something like that. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632