From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: build fixes Date: Tue, 12 Jan 2010 18:47:59 +0100 Message-ID: <201001121847.59815.Christoph.Egger@amd.com> References: <4B4CB49A.90802@cs.ubc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4B4CB49A.90802@cs.ubc.ca> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Patrick Colp Cc: "xen-devel@lists.xensource.com" , Ian Jackson , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Tuesday 12 January 2010 18:42:50 Patrick Colp wrote: > Keir Fraser wrote: > > On 12/01/2010 17:22, "Ian Jackson" wrote: > >>> - seek_ret = lseek64(fd, i << PAGE_SHIFT, SEEK_SET); > >>> + seek_ret = lseek(fd, i << PAGE_SHIFT, SEEK_SET); > >> > >> This is just wrong. It will break on >2G files. > > > > We build everything under tools/ with LFS support enabled, so off_t is 64 > > bits even in 32-bit environments. FYI The bits to enable LFS support are > > in tools/Rules.mk. > > According to the lseek64 man page, for 32-bit architectures to have 64-bit > off_t, you need: > > #define _FILE_OFFSET_BITS 64 > > Which, as far as I know, isn't set. LFS just makes lseek64 available > (without it, the function doesn't exist). Ah, good to know. Since lseek64() isn't POSIX and therefore breaks build on non-Linux, LFS should be disabled and -D_FILE_OFFSET_BITS=64 should be used in CFLAGS under tools/ . Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632