All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCHv7 3/3] virtio: add features as qdev properties
Date: Tue, 12 Jan 2010 21:50:55 +0200	[thread overview]
Message-ID: <20100112195055.GC3170@redhat.com> (raw)
In-Reply-To: <20100112180927.GA1510@lst.de>

On Tue, Jan 12, 2010 at 07:09:27PM +0100, Christoph Hellwig wrote:
> This patch causes 100% reproducible boot panics in a Linux guest using
> virtio.
> 
> My qemu command line is:
> 
> /opt/qemu/bin/qemu-system-x86_64 \
>         -m 1500 \
> 	-enable-kvm \
> 	-drive file=/dev/vg00/qemu-root,if=virtio,media=disk,cache=none,aio=threads \
> 	-kernel arch/x86/boot/bzImage \
> 	-append "root=/dev/vda console=tty0 console=ttyS0,38400n8" \
> 	-nographic
> 
> and the guest dmesg is:

So the issue is that wrong block size (0xffffffff) was passed
to guest.  Would it make sense to add some sanity checking in virtio-blk
to make it not crash but fail in probe? Which block size values
are sane?

-- 
MST

  parent reply	other threads:[~2010-01-12 19:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1263124239.git.mst@redhat.com>
2010-01-10 11:52 ` [Qemu-devel] [PATCHv7 1/3] qdev: add bit property type Michael S. Tsirkin
2010-01-11 19:50   ` Anthony Liguori
2010-01-10 11:52 ` [Qemu-devel] [PATCHv7 2/3] virtio: rename features -> guest_features Michael S. Tsirkin
2010-01-10 11:52 ` [Qemu-devel] [PATCHv7 3/3] virtio: add features as qdev properties Michael S. Tsirkin
2010-01-12 17:05   ` [Qemu-devel] " Gerd Hoffmann
2010-01-12 18:50     ` Michael S. Tsirkin
2010-01-12 18:09   ` [Qemu-devel] " Christoph Hellwig
2010-01-12 18:52     ` Michael S. Tsirkin
2010-01-12 19:50     ` Michael S. Tsirkin [this message]
2010-01-12 22:06       ` Christoph Hellwig
2010-01-13 10:43         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100112195055.GC3170@redhat.com \
    --to=mst@redhat.com \
    --cc=hch@lst.de \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.