From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: fix __ocfs2_cluster_lock() dead lock
Date: Tue, 12 Jan 2010 23:57:53 -0800 [thread overview]
Message-ID: <20100113075752.GA23372@mail.oracle.com> (raw)
In-Reply-To: <20100113032049.GA4045@laptop.oracle.com>
On Wed, Jan 13, 2010 at 11:20:49AM +0800, Wengang Wang wrote:
> before update_holders, the lock could be DCed(since no BUSY flag set by
> here).
>
> and even after update_holders, the lock could be DCed too.
>
> so that we get ocfs2_cluster_lock()(with holders increased) returned sucessfully
> but actually we don't hold the dlm lock. --thus more than one node is
> considering that they have the (EX) lock.
You make a good point. I don't like the solution you propose,
though. Another flag that's almost the same? Eww! There's got to be a
better way.
Joel
--
Life's Little Instruction Book #80
"Slow dance"
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-01-13 7:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 8:34 [Ocfs2-devel] [PATCH] ocfs2: fix __ocfs2_cluster_lock() dead lock Wengang Wang
2010-01-07 2:00 ` Joel Becker
2010-01-07 5:22 ` Wengang Wang
2010-01-09 18:05 ` Wengang Wang
2010-01-09 18:24 ` Sunil Mushran
2010-01-10 10:05 ` Joel Becker
2010-01-11 1:55 ` Wengang Wang
2010-01-12 1:59 ` Joel Becker
2010-01-12 3:58 ` Wengang Wang
2010-01-12 11:18 ` Joel Becker
2010-01-12 12:04 ` Wengang Wang
2010-01-12 13:01 ` Joel Becker
2010-01-12 14:30 ` Wengang Wang
2010-01-12 19:14 ` Sunil Mushran
2010-01-13 6:15 ` Wengang Wang
2010-01-12 19:47 ` David Teigland
2010-01-13 3:20 ` Wengang Wang
2010-01-13 7:08 ` Wengang Wang
2010-01-13 7:57 ` Joel Becker [this message]
2010-01-13 9:23 ` Wengang Wang
2010-01-13 9:31 ` Joel Becker
2010-01-13 9:36 ` Wengang Wang
2010-01-13 19:14 ` Sunil Mushran
2010-01-14 1:01 ` Joel Becker
2010-01-14 4:12 ` Wengang Wang
2010-01-21 15:30 ` David Teigland
2010-01-21 15:41 ` Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113075752.GA23372@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.