From: Alexey Dobriyan <adobriyan@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, containers@lists.linux-foundation.org
Subject: Re: [PATCH 1/2] nfnetlink: add netns support
Date: Wed, 13 Jan 2010 15:22:56 +0200 [thread overview]
Message-ID: <20100113132255.GA16975@x200> (raw)
In-Reply-To: <4B4DC469.5000408@trash.net>
On Wed, Jan 13, 2010 at 02:02:33PM +0100, Patrick McHardy wrote:
> Alexey Dobriyan wrote:
> > + struct sock *nfnl;
> > + struct sock *nfnl_stash;
>
> Shouldn't this be contained in an ifdef(CONFIG_NETFILTER_NETLINK)
> (_MODULE) ?
No, otherwise you won't be able to start using, e. g., nfnetlink_log
module on NETFILTER_NETLINK=n kernels without reboot.
> The remaining parts look good to me.
OK, I'll resend shortly.
next prev parent reply other threads:[~2010-01-13 13:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 12:24 [PATCH 1/2] nfnetlink: add netns support Alexey Dobriyan
2010-01-13 13:02 ` Patrick McHardy
[not found] ` <4B4DC469.5000408-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2010-01-13 13:22 ` Alexey Dobriyan
2010-01-13 13:22 ` Alexey Dobriyan [this message]
2010-01-13 13:27 ` Patrick McHardy
2010-01-13 13:27 ` Patrick McHardy
[not found] ` <4B4DCA2C.7020000-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2010-01-13 13:37 ` Alexey Dobriyan
2010-01-13 13:37 ` Alexey Dobriyan
2010-01-13 13:42 ` Patrick McHardy
2010-01-13 13:42 ` Patrick McHardy
[not found] ` <4B4DCDA8.5070108-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2010-01-13 13:47 ` Alexey Dobriyan
2010-01-13 13:47 ` Alexey Dobriyan
2010-01-13 13:49 ` Patrick McHardy
2010-01-13 13:49 ` Patrick McHardy
2010-01-13 13:02 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2010-01-13 12:24 Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113132255.GA16975@x200 \
--to=adobriyan@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.