From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nickolas Subject: Re: [PATCH] - fix speaker output for toshiba nb205 netbooks Date: Wed, 13 Jan 2010 14:13:08 -0500 Message-ID: <20100113141308.39344e5c@nick-PC> References: <20100112165832.35b5d23f@nick-PC> <20100113110611.73625b1e@nick-PC> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from qw-out-1920.google.com (qw-out-1920.google.com [74.125.92.144]) by alsa0.perex.cz (Postfix) with ESMTP id 50EB6103818 for ; Wed, 13 Jan 2010 20:13:12 +0100 (CET) Received: by qw-out-1920.google.com with SMTP id 14so4178233qwa.56 for ; Wed, 13 Jan 2010 11:13:10 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Wed, 13 Jan 2010 17:17:20 +0100 Takashi Iwai wrote: > At Wed, 13 Jan 2010 11:06:11 -0500, > Nickolas wrote: > > > > On Wed, 13 Jan 2010 09:14:32 +0100 > > Takashi Iwai wrote: > > > > > At Tue, 12 Jan 2010 16:58:32 -0500, > > > Nickolas wrote: > > > > > > > > this is a quick fix i wrote up a couple days ago to fix speaker > > > > output on the Realtek ALC272 codec present in toshiba nb205 > > > > netbooks. presently, speaker output doesn't work at all on this > > > > model, regardless of settings in the mixer. this is because the > > > > current driver thinks the speaker is at nid 0x0c instead of the > > > > correct 0x17. i'm not too familiar with this hardware, so i'm not > > > > sure that this patch won't have any negative effects for other > > > > hardware. it also seems like a messy way of fixing the problem. > > > > any comments or suggestions are welcome, as is testing for those who > > > > have this board. diffed against the latest git. > > > > > > Thanks for the patch. The change looks safe to me. > > > > > > But I'm still wondering whether model=auto doesn't work for this device. > > > Could you try it with the latest driver? > > > > > > > > > thanks, > > > > > > Takashi > > > > > > > hmm, i feel stupid. so, it works with model=auto, but why is that not implied when the model parameter isn't specified on the command line? > > OK, that's good to hear. IIRC, the quirk was there because it didn't work > with model=auto, at least, at that time. > > I guess it's time to back to auto option again. I'll fix now. > > Thanks for quick testing! > > > Takashi no problem. i'll test all the ports later today when i have time to make sure that they work properly with model=auto, just to be sure. thanks for the help! Nick