From: Andrew Morton <akpm@linux-foundation.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] procfs: Fix refcnt leak on proc_self_follow_link() error path
Date: Wed, 13 Jan 2010 16:25:04 -0800 [thread overview]
Message-ID: <20100113162504.1c06c5e6.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100113194300.GA4673@ZenIV.linux.org.uk>
On Wed, 13 Jan 2010 19:43:01 +0000
Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Tue, Jan 12, 2010 at 03:38:36AM +0900, OGAWA Hirofumi wrote:
> >
> > If ->follow_link handler return the error, it should decrement
> > nd->path refcnt.
> >
> > This patch fix it.
>
> It's OK for -stable, but for the next tree... not really. I'd rather
> kill vfs_follow_link() uses here and in gfs2; see #untested in vfs-2.6.git
> for details.
Confused. Is #untested planned for 2.6.33? If not, how do we fix this
bug in .33?
next prev parent reply other threads:[~2010-01-14 0:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 18:38 [PATCH] procfs: Fix refcnt leak on proc_self_follow_link() error path OGAWA Hirofumi
2010-01-13 19:43 ` Al Viro
2010-01-14 0:25 ` Andrew Morton [this message]
2010-01-14 1:55 ` Al Viro
2010-02-04 19:31 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113162504.1c06c5e6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.